Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoom in and out icon's "title" should be translatable. #273

Open
readingdancer opened this issue Sep 1, 2020 · 1 comment · May be fixed by #278
Open

Zoom in and out icon's "title" should be translatable. #273

readingdancer opened this issue Sep 1, 2020 · 1 comment · May be fixed by #278
Labels
bug Something isn't working good first issue Good for newcomers Hackathon Issues we think could be tackled during a Hackathon Up for grabs Anyone can offer to take on these tickets

Comments

@readingdancer
Copy link
Contributor

Describe the bug
The zoom icons have their title's hard coded in English.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the site on a desktop or laptop and search for something so that you can see the map
  2. Change the language to anything other than English
  3. Hover your mouse over the zoom in and out icons and look at the title text that should pop up
  4. The pop up text will be in English

Expected behavior
The pop up text should be in the language you selected in step 2.

This functionality is provided by the LeafletJS plugin, so I am not sure how we are going to pass in the translatable variable... this is something you will need to find out :)
@readingdancer readingdancer added the bug Something isn't working label Sep 1, 2020
@readingdancer readingdancer added good first issue Good for newcomers Hackathon Issues we think could be tackled during a Hackathon Up for grabs Anyone can offer to take on these tickets labels Sep 1, 2020
@aevix
Copy link

aevix commented Sep 7, 2020

I can try this problem!

@aevix aevix linked a pull request Sep 28, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers Hackathon Issues we think could be tackled during a Hackathon Up for grabs Anyone can offer to take on these tickets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 273 aevix/NC-COVID-Support
2 participants
@readingdancer @aevix