✨ feat: filter컴포넌트 구현 #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
linked an issue
Closed
Moon-ju-young
requested changes
Jun 20, 2025
Contributor
Moon-ju-young
left a comment
Moon-ju-young
left a comment
There was a problem hiding this comment.
아직 모바일 구현이 덜 된 것 같네요!
src/components/common/Filter.tsx
Outdated
| <div className="z-5 flex w-full max-w-390 flex-col gap-24 rounded-[10px] border border-gray-20 bg-white px-20 py-24 shadow-custom"> | ||
| <div className="flex flex-row items-center justify-between text-[2rem] leading-[2.4rem]"> | ||
| <h3 className="text-h3 font-bold">상세 필터</h3> | ||
| <div className="z-5 flex w-full max-w-390 flex-col gap-24 rounded-xl border border-gray-20 bg-white px-12 py-24 shadow-custom md:px-20"> |
Contributor
There was a problem hiding this comment.
💬 border 때문에 1px 줄여줘야 맞지 않을까 싶네요~
Suggested change
| <div className="z-5 flex w-full max-w-390 flex-col gap-24 rounded-xl border border-gray-20 bg-white px-12 py-24 shadow-custom md:px-20"> | |
| <div className="z-5 flex w-full max-w-390 flex-col gap-24 rounded-xl border border-gray-20 bg-white px-12 py-24 shadow-custom md:px-19"> |
src/components/common/Filter.tsx
Outdated
| <div className="flex gap-4"> | ||
| <Button solid={false} className="w-80" onClick={handleReset}> | ||
| <div className="fixed right-0 bottom-0 left-0 flex w-full gap-8 border-t border-gray-20 bg-white px-12 py-16 md:static md:border-none md:p-0"> | ||
| <Button solid={false} className="w-82" onClick={handleReset}> |
Contributor
There was a problem hiding this comment.
Suggested change
| <Button solid={false} className="w-82" onClick={handleReset}> | |
| <Button solid={false} className="w-82 flex-1" onClick={handleReset}> |
💬 이런 식으로 추가해야 아래 버튼의 여백이 없을 것 같습니다~
Moon-ju-young
approved these changes
Jun 20, 2025
minimo-9
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 변경 사항 개요
📝 상세 내용
🔗 관련 이슈
🖼️ 스크린샷(선택사항)
💡 참고 사항