Skip to content

✨ feat: filter컴포넌트 구현 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minimo-9 merged 4 commits into from
Jun 21, 2025
Merged

✨ feat: filter컴포넌트 구현 #93

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a35c2ce
🎨 style: 필터 컴포넌트 레이아웃 및 여백 조정
minimo-9 Jun 20, 2025
f5c5fcd
🐛 fix: 피드백 적용 완료
minimo-9 Jun 20, 2025
45e4da3
🎨 style: 필터 컴포넌트의 여백 조정
minimo-9 Jun 20, 2025
ad8d44c
Merge branch 'develop' into feat/filter
minimo-9 Jun 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/components/common/Filter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export default function Filter({
if (!open) return null;

return (
<div className="z-5 flex w-full max-w-390 flex-col gap-24 rounded-xl border border-gray-20 bg-white px-20 py-24 shadow-custom">
<div className="z-5 flex w-full max-w-390 flex-col gap-24 rounded-xl border border-gray-20 bg-white px-12 py-24 shadow-custom md:px-20">
Copy link
Contributor

@Moon-ju-young Moon-ju-young Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 border 때문에 1px 줄여줘야 맞지 않을까 싶네요~

Suggested change
<div className="z-5 flex w-full max-w-390 flex-col gap-24 rounded-xl border border-gray-20 bg-white px-12 py-24 shadow-custom md:px-20">
<div className="z-5 flex w-full max-w-390 flex-col gap-24 rounded-xl border border-gray-20 bg-white px-12 py-24 shadow-custom md:px-19">

<div className="flex flex-row items-center justify-between">
<h3 className="text-h3 font-bold text-black">상세 필터</h3>
<button
Expand Down Expand Up @@ -129,7 +129,7 @@ export default function Filter({

<HorizontalLine />

<div className="mb-40 flex items-end gap-12">
<div className="mb-80 flex items-end gap-12 md:mb-40">
<div className="flex-1">
<Input
label="금액"
Expand All @@ -144,11 +144,11 @@ export default function Filter({
<span className="flex-1 pb-16 text-body1/26">이상부터</span>
</div>

<div className="flex gap-8">
<Button solid={false} className="w-80" onClick={handleReset}>
<div className="fixed right-0 bottom-0 left-0 flex w-full gap-8 border-t border-gray-20 bg-white px-12 py-16 md:static md:border-none md:p-0">
<Button solid={false} className="w-82" onClick={handleReset}>
Copy link
Contributor

@Moon-ju-young Moon-ju-young Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Button solid={false} className="w-82" onClick={handleReset}>
<Button solid={false} className="w-82 flex-1" onClick={handleReset}>

💬 이런 식으로 추가해야 아래 버튼의 여백이 없을 것 같습니다~

초기화
</Button>
<Button className="flex-1 md:w-240" onClick={handleApply}>
<Button className="w-260" onClick={handleApply}>
적용하기
</Button>
</div>
Expand Down