Skip to content

♻️ Refact: Frame 컴포넌트 Button 적용 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sohyun0 merged 4 commits into from
Oct 9, 2025
Merged

♻️ Refact: Frame 컴포넌트 Button 적용 #41

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbf66f4
♻️ Refact: Frame 컴포넌트 Button 적용
BaeZzi813 Oct 8, 2025
fa87963
Merge branch 'develop' of https://github.com/codeit-FE18-part3/Thejul…
BaeZzi813 Oct 8, 2025
0c10ab5
♻️ Refact: 반응형 div 태그로 묶어서 컨테이너 수정
BaeZzi813 Oct 8, 2025
6624ae8
♻️ Reafct: Container 적용 반응형 수정
BaeZzi813 Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions src/components/layout/frame/frame.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,27 @@
import Button from '@/components/ui/button/button';
import Link from 'next/link';

interface FrameProps {
title: string;
content: string;
buttonText: string;
href: string;
}

const Frame = ({ title, content }: FrameProps) => {
const Frame = ({ title, content, buttonText, href }: FrameProps) => {
return (
<>
<section className='flex flex-col gap-4 px-3 py-10 tablet:px-8 tablet:py-[60px] desktop:px-[237px] desktop:py-[60px]'>
<h1 className='text-heading-s font-bold tablet:text-heading-l'>{title}</h1>
<div className='flex flex-col items-center justify-center gap-4 rounded-xl border border-solid border-gray-200 px-6 py-[60px]'>
<h2 className='text-body-s font-normal tablet:text-body-l'>{content}</h2>
{/* 버튼 컴포넌트 넣을 자리 */}
<section className='flex flex-col gap-4 px-3 py-10 tablet:px-8 tablet:py-[60px]'>
<div className='mx-auto w-full max-w-5xl'>
Copy link
Contributor

@sohyun0 sohyun0 Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max-w-5xl 면 1024px 인데 레이아웃 컨테이너는 1028px 이여서 혹시 container 컴포넌트를 사용하는건 어려울까요??
그리고 max-width 는 section 에 주어야 될것 같습니다! 프레임의 크기는 피그마기준 964px 로 나오는데 저렇게 작성되면 1024로 나올것으로 예상됩니다 :'(

또한 이렇게 section 바로 밑에 div 가 있으면 h1이랑 간격주려고 flex flex-col 한건데 의미가 사라질것 같습니다!

제안 : 기존에 작성된 컴포넌트를 활용하면 어떨까요?
태그도 줄일 수 있고 기존에 하려던 레이아웃도 동일하게 나오는것 같습니다

      <Container as='section' className='flex flex-col gap-4 py-10 tablet:py-[60px]'>
        <h1 className='text-heading-s font-bold tablet:text-heading-l'>{title}</h1>
      </Container>

밑에있는 프레임이 현재 container 컴포넌트 적용된 모습입니다!

스크린샷 2025-10-09 오전 12 01 07

Copy link
Contributor Author

@BaeZzi813 BaeZzi813 Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS 아직 멀었네요..ㅠㅠ 말씀해주신 내용으로 수정했습니다! Frame 최대 964px 로 되었고, div 삭제하고 Container 로 적용했습니다!

<h1 className='mb-4 text-heading-s font-bold tablet:text-heading-l'>{title}</h1>
<div className='flex flex-col items-center justify-center gap-4 rounded-xl border border-solid border-gray-200 px-6 py-[60px]'>
<h2 className='text-body-s font-normal tablet:text-body-l'>{content}</h2>
<div className='tablet:w-[346px]'>
<Button size='md' as={Link} href={href} full>
{buttonText}
</Button>
</div>
</div>
</div>
</section>
</>
Expand Down