-
Notifications
You must be signed in to change notification settings - Fork 4
♻️ Refact: Frame 컴포넌트 Button 적용 #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Refact: Frame 컴포넌트 Button 적용
|
@BaeZzi813 is attempting to deploy a commit to the projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sohyun0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 ! 코멘트 확인부탁드립니다
| const Frame = ({ title, content, buttonText, href }: FrameProps) => { | ||
| return ( | ||
| <> | ||
| <section className='flex flex-col gap-4 px-3 py-10 tablet:px-8 tablet:py-[60px] desktop:px-[237px] desktop:py-[60px]'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인 감사합니다! div 태그로 전체 묶어서 max-w 넣어서 수정하였습니다!
Refact: 반응형 div 태그로 묶어서 컨테이너 수정
| <section className='flex flex-col gap-4 px-3 py-10 tablet:px-8 tablet:py-[60px]'> | ||
| <div className='mx-auto w-full max-w-5xl'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
max-w-5xl 면 1024px 인데 레이아웃 컨테이너는 1028px 이여서 혹시 container 컴포넌트를 사용하는건 어려울까요??
그리고 max-width 는 section 에 주어야 될것 같습니다! 프레임의 크기는 피그마기준 964px 로 나오는데 저렇게 작성되면 1024로 나올것으로 예상됩니다 :'(
또한 이렇게 section 바로 밑에 div 가 있으면 h1이랑 간격주려고 flex flex-col 한건데 의미가 사라질것 같습니다!
제안 : 기존에 작성된 컴포넌트를 활용하면 어떨까요?
태그도 줄일 수 있고 기존에 하려던 레이아웃도 동일하게 나오는것 같습니다
<Container as='section' className='flex flex-col gap-4 py-10 tablet:py-[60px]'>
<h1 className='text-heading-s font-bold tablet:text-heading-l'>{title}</h1>
</Container>
밑에있는 프레임이 현재 container 컴포넌트 적용된 모습입니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSS 아직 멀었네요..ㅠㅠ 말씀해주신 내용으로 수정했습니다! Frame 최대 964px 로 되었고, div 삭제하고 Container 로 적용했습니다!
sohyun0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다 고생 많으셨습니다 :)

📝 작업 개요 (필수)
Frame 컴포넌트에 신천님 작업하신 Button 적용하고 Link 설정
✨ 작업 내용 (필수)
📸 스크린샷
🧐 해결해야 하는 문제
🤔 리뷰어 확인 필요 사항
🔗 관련 이슈
🛠️ 후속 작업
✅ 체크리스트 (필수)