Skip to content

♻️ Refact: Frame 컴포넌트 Button 적용 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sohyun0 merged 4 commits into from
Oct 9, 2025
Merged

♻️ Refact: Frame 컴포넌트 Button 적용 #41

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbf66f4
♻️ Refact: Frame 컴포넌트 Button 적용
BaeZzi813 Oct 8, 2025
fa87963
Merge branch 'develop' of https://github.com/codeit-FE18-part3/Thejul…
BaeZzi813 Oct 8, 2025
0c10ab5
♻️ Refact: 반응형 div 태그로 묶어서 컨테이너 수정
BaeZzi813 Oct 8, 2025
6624ae8
♻️ Reafct: Container 적용 반응형 수정
BaeZzi813 Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/components/layout/frame/frame.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,25 @@
import Button from '@/components/ui/button/button';
import Link from 'next/link';

interface FrameProps {
title: string;
content: string;
buttonText: string;
href: string;
}

const Frame = ({ title, content }: FrameProps) => {
const Frame = ({ title, content, buttonText, href }: FrameProps) => {
return (
<>
<section className='flex flex-col gap-4 px-3 py-10 tablet:px-8 tablet:py-[60px] desktop:px-[237px] desktop:py-[60px]'>
Copy link
Contributor

@sohyun0 sohyun0 Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스크린샷 2025-10-08 오후 6 59 27 기존 프레임 테스트 해봤는데 1030px 일때 전체로 보여야 할것 같은데 작게 보이더라구요!

desktop:px-[237px] 이부분 여백이 아닌 컨테이너로 설정해야할것 같아보입니다

Copy link
Contributor Author

@BaeZzi813 BaeZzi813 Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 감사합니다! div 태그로 전체 묶어서 max-w 넣어서 수정하였습니다!

<h1 className='text-heading-s font-bold tablet:text-heading-l'>{title}</h1>
<div className='flex flex-col items-center justify-center gap-4 rounded-xl border border-solid border-gray-200 px-6 py-[60px]'>
<h2 className='text-body-s font-normal tablet:text-body-l'>{content}</h2>
{/* 버튼 컴포넌트 넣을 자리 */}
<div className='tablet:w-[346px]'>
<Button size='md' as={Link} href={href} full>
{buttonText}
</Button>
</div>
</div>
</section>
</>
Expand Down
Loading