-
Notifications
You must be signed in to change notification settings - Fork 39
[유용민] sprint1 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "Basic-\uC720\uC6A9\uBBFC-sprint1"
[유용민] sprint1 #14
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| .main-article { | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| padding: 50px 0; | ||
| } | ||
|
|
||
| .main-article-container { | ||
| display: flex; | ||
| width: 988px; | ||
| height: 444px; | ||
| } | ||
|
|
||
| .main-article__text { | ||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: center; | ||
| background-color: #fcfcfc; | ||
| gap: 24px; | ||
| padding: 30px 40px; | ||
| h5 { | ||
| font-size: 18px; | ||
| font-weight: 700; | ||
| line-height: 26px; | ||
| color: #3692ff; | ||
| } | ||
| h2 { | ||
| font-size: 40px; | ||
| font-weight: 700; | ||
| line-height: 56px; | ||
| } | ||
| p { | ||
| font-size: 24px; | ||
| line-height: 32px; | ||
| font-weight: 500; | ||
| } | ||
| } | ||
|
|
||
| .main-article__text2 { | ||
| align-items: flex-end; | ||
| text-align: right; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| .main-banner { | ||
| display: flex; | ||
| justify-content: center; | ||
| background-color: #cfe5ff; | ||
| width: 100%; | ||
| height: 540px; | ||
| } | ||
|
|
||
| banner { | ||
| display: flex; | ||
| align-items: flex-end; | ||
| justify-content: center; | ||
| width: 100%; | ||
| max-width: 1920px; | ||
| height: 100%; | ||
| } | ||
|
|
||
| .main-banner__content { | ||
| display: flex; | ||
| flex-direction: column; | ||
| align-items: flex-start; | ||
| width: 357px; | ||
| height: 260px; | ||
| font-size: 40px; | ||
| font-weight: 700; | ||
| line-height: 56px; | ||
| gap: 32px; | ||
| margin-bottom: 40px; | ||
| a { | ||
| width: 100%; | ||
| } | ||
| button { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| width: 100%; | ||
| height: 56px; | ||
| border-radius: 40px; | ||
| background-color: #3692ff; | ||
| color: #ffffff; | ||
| cursor: pointer; | ||
| } | ||
| } | ||
|
|
||
| .main-banner-bottom__content { | ||
| margin-bottom: 0; | ||
| } | ||
|
|
||
| @media (max-width: 1920px) { | ||
| banner { | ||
| width: calc(100% - 400px); | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| footer { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| width: 100vw; | ||
| height: 160px; | ||
| background-color: #111827; | ||
| } | ||
|
|
||
| .footer-container { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: space-between; | ||
| width: 1120px; | ||
| color: #ffffff; | ||
| font-size: 16px; | ||
| line-height: 19.09px; | ||
| font-weight: 400; | ||
| } | ||
|
|
||
| .footer-middle { | ||
| display: flex; | ||
| gap: 30px; | ||
| } | ||
|
|
||
| .footer-right { | ||
| display: flex; | ||
| gap: 12px; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| header { | ||
| display: flex; | ||
| justify-content: center; | ||
| } | ||
|
|
||
| nav { | ||
| display: flex; | ||
| justify-content: space-around; | ||
| align-items: center; | ||
| width: 100%; | ||
| max-width: 1920px; | ||
| height: 70px; | ||
| padding: 9px 0; | ||
| a { | ||
| height: 100%; | ||
| } | ||
| img { | ||
| height: 100%; | ||
| } | ||
| button { | ||
| width: 128px; | ||
| height: 48px; | ||
| padding: 0.5rem 1.45rem; | ||
| border-radius: 8px; | ||
| border: none; | ||
| color: #ffffff; | ||
| background-color: #3692ff; | ||
| cursor: pointer; | ||
| } | ||
| } | ||
|
|
||
| @media (max-width: 1920px) { | ||
| nav { | ||
| justify-content: space-between; | ||
| width: calc(100% - 400px); | ||
| } | ||
| } |
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| /* http://meyerweb.com/eric/tools/css/reset/ | ||
| v2.0 | 20110126 | ||
| License: none (public domain) | ||
| */ | ||
|
|
||
| html, | ||
| body, | ||
| div, | ||
| span, | ||
| applet, | ||
| object, | ||
| iframe, | ||
| h1, | ||
| h2, | ||
| h3, | ||
| h4, | ||
| h5, | ||
| h6, | ||
| p, | ||
| blockquote, | ||
| pre, | ||
| a, | ||
| abbr, | ||
| acronym, | ||
| address, | ||
| big, | ||
| cite, | ||
| code, | ||
| del, | ||
| dfn, | ||
| em, | ||
| img, | ||
| ins, | ||
| kbd, | ||
| q, | ||
| s, | ||
| samp, | ||
| small, | ||
| strike, | ||
| strong, | ||
| sub, | ||
| sup, | ||
| tt, | ||
| var, | ||
| b, | ||
| u, | ||
| i, | ||
| center, | ||
| dl, | ||
| dt, | ||
| dd, | ||
| ol, | ||
| ul, | ||
| li, | ||
| fieldset, | ||
| form, | ||
| label, | ||
| legend, | ||
| table, | ||
| caption, | ||
| tbody, | ||
| tfoot, | ||
| thead, | ||
| tr, | ||
| th, | ||
| td, | ||
| article, | ||
| aside, | ||
| canvas, | ||
| details, | ||
| embed, | ||
| figure, | ||
| figcaption, | ||
| footer, | ||
| header, | ||
| hgroup, | ||
| menu, | ||
| nav, | ||
| output, | ||
| ruby, | ||
| section, | ||
| summary, | ||
| time, | ||
| mark, | ||
| audio, | ||
| video { | ||
| margin: 0; | ||
| padding: 0; | ||
| border: 0; | ||
| font-size: 100%; | ||
| font: inherit; | ||
| vertical-align: baseline; | ||
| } | ||
| /* HTML5 display-role reset for older browsers */ | ||
| article, | ||
| aside, | ||
| details, | ||
| figcaption, | ||
| figure, | ||
| footer, | ||
| header, | ||
| hgroup, | ||
| menu, | ||
| nav, | ||
| section { | ||
| display: block; | ||
| } | ||
| body { | ||
| line-height: 1; | ||
| } | ||
| ol, | ||
| ul { | ||
| list-style: none; | ||
| } | ||
| blockquote, | ||
| q { | ||
| quotes: none; | ||
| } | ||
| blockquote:before, | ||
| blockquote:after, | ||
| q:before, | ||
| q:after { | ||
| content: ""; | ||
| content: none; | ||
| } | ||
| table { | ||
| border-collapse: collapse; | ||
| border-spacing: 0; | ||
| } |
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 칭찬 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| @import "reset.css"; | ||
|
|
||
| /* components */ | ||
| @import "components/nav.css"; | ||
| @import "components/banner.css"; | ||
| @import "components/articles.css"; | ||
| @import "components/footer.css"; | ||
|
|
||
| @font-face { | ||
| font-family: "Pretendard-Regular"; | ||
| src: url("https://fastly.jsdelivr.net/gh/Project-Noonnu/[email protected]/Pretendard-Regular.woff") | ||
| format("woff"); | ||
|
Comment on lines
+10
to
+12
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💊 제안 용민님 폰트 잘 적용하셨습니다. 이는 최적화를 위한 제안이므로 시간이 되실때 적용해보시면 좋을 것 같습니다~ |
||
| font-weight: 400; | ||
| font-style: normal; | ||
| } | ||
|
|
||
| * { | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| body { | ||
| font-family: "Pretendard-Regular"; | ||
| width: 100vw; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❗️ 수정요청 https://dev.to/tepythai/why-100vw-causes-horizontal-scrollbar-4nlm |
||
| } | ||
|
|
||
| button { | ||
| border: none; | ||
| } | ||
|
|
||
| a { | ||
| text-decoration: none; | ||
| color: inherit; | ||
| } | ||
|
Comment on lines
+26
to
+33
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💊 제안 |
||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💊 제안 |


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💊 제안
해당 line-height 값을 아마 figma에서 보고 추가하셨을 것 같아요.
다만 아래 속성값은 사실 의미가 없을 가능성이 큽니다.
피그마는 디자인을 보고 css 값들을 나열하고, 해당 값이 실제로 구현하는데 필수적인지는 알 수 없습니다.
그래서 피그마 속성값을 그대로 쓰시기보다 참고만해주세요~
그리고 line-height 값이 필요하시더라도 정수로 사용하시는 것이 좋습니다~