Style: 시맨틱 태그 변경 및 Profile 이미지 svg로 변경 #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
venise5224
commented
Nov 6, 2024
venise5224
commented
- 헤더 시멘틱 태그 적용
- Profile 이미지 png -> svg / star 이미지 svg 불가
mungyun
approved these changes
Nov 7, 2024
Contributor
mungyun
left a comment
mungyun
left a comment
There was a problem hiding this comment.
고생하셨습니당~ footer도 시맨틱태그 사용하면 좋을 것 같습니당
99minji
approved these changes
Nov 7, 2024
Comment on lines
+8
to
+18
| <header className="bg-gray100 py-[13px] px-[32px] md:py-[33px] md:px-[200px]"> | ||
| <div className="flex justify-between items-center max-w-[1520px]"> | ||
| <Link | ||
| href={"/"} | ||
| className="w-[88.67px] h-[16px] md:w-[133px] md:h-[24px]" | ||
| > | ||
| <Image src={Logo} width={133} height={24} alt="로고" /> | ||
| </Link> | ||
| <HeaderMenu /> | ||
| </div> | ||
| </div> | ||
| </header> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.