Skip to content

Style: 시맨틱 태그 변경 및 Profile 이미지 svg로 변경 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
venise5224 merged 1 commit into from
Nov 7, 2024
Merged

Style: 시맨틱 태그 변경 및 Profile 이미지 svg로 변경 #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/HeaderMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Image from "next/image";
import Profile from "@/public/icons/profile.png";
import Profile from "@/public/icons/profile.svg";
import Star from "@/public/icons/star.png";
import Link from "next/link";
import Button from "./Button";
Expand Down
22 changes: 10 additions & 12 deletions components/Layout/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,17 @@ import HeaderMenu from "../HeaderMenu";

const Header = () => {
return (
<div>
<div className="bg-gray100 py-[13px] px-[32px] md:py-[33px] md:px-[200px]">
<div className="flex justify-between items-center max-w-[1520px]">
<Link
href={"/"}
className="w-[88.67px] h-[16px] md:w-[133px] md:h-[24px]"
>
<Image src={Logo} width={133} height={24} alt="로고" />
</Link>
<HeaderMenu />
</div>
<header className="bg-gray100 py-[13px] px-[32px] md:py-[33px] md:px-[200px]">
<div className="flex justify-between items-center max-w-[1520px]">
<Link
href={"/"}
className="w-[88.67px] h-[16px] md:w-[133px] md:h-[24px]"
>
<Image src={Logo} width={133} height={24} alt="로고" />
</Link>
<HeaderMenu />
</div>
</div>
</header>
Comment on lines +8 to +18
Copy link
Collaborator

@99minji 99minji Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

시맨틱 태그 잘 사용하셨군요 👍

);
};

Expand Down
Binary file removed public/icons/profile.png
View file
Open in desktop
Binary file not shown.
4 changes: 4 additions & 0 deletions public/icons/profile.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading