Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix byte 0x92 #19

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix byte 0x92 #19

merged 1 commit into from
Jan 11, 2024

Conversation

bongbui321
Copy link
Contributor

@bongbui321 bongbui321 commented Jan 9, 2024 •
edited
Loading

For #29500 and this PR. Probably the file was written on a Windows machine using encoding cp1252. Having this character (0x92) create error while Scanner of SCons was scanning the file as shown below. Needed this change to enable new scons Scanner for warn=all in openpilot. SCons Scanner uses utf-8 for encoding.

scons: done reading SConscript files.
scons: Building targets ...
scons: *** [body/board/bldc-body.o] UnicodeDecodeError : 'utf-8' codec can't decode byte 0x92 in position 576: invalid start byte
scons: building terminated because of errors.```

@bongbui321 bongbui321 mentioned this pull request Jan 9, 2024
Merged
@adeebshihadeh adeebshihadeh merged commit 61ace31 into commaai:master Jan 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bongbui321 @adeebshihadeh