Skip to content

Commit 6756948

Browse files
committed
raw desired curvature as input to all controllers
1 parent e39c02a commit 6756948

File tree

4 files changed

+5
-11
lines changed

4 files changed

+5
-11
lines changed

selfdrive/controls/controlsd.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -123,14 +123,8 @@ def state_control(self):
123123
curvature_limited = curvature_limited or raw_curvature_limited
124124

125125
actuators.curvature = self.desired_curvature
126-
127-
if self.CP.lateralTuning.which() == 'torque':
128-
steer, steeringAngleDeg, lac_log = self.LaC.update(CC.latActive, CS, self.VM, lp,
129-
self.steer_limited_by_safety, self.desired_curvature, new_raw_desired_curvature,
130-
curvature_limited) # TODO what if not available
131-
else:
132-
steer, steeringAngleDeg, lac_log = self.LaC.update(CC.latActive, CS, self.VM, lp,
133-
self.steer_limited_by_safety, self.desired_curvature,
126+
steer, steeringAngleDeg, lac_log = self.LaC.update(CC.latActive, CS, self.VM, lp,
127+
self.steer_limited_by_safety, self.desired_curvature, self.raw_desired_curvature,
134128
curvature_limited) # TODO what if not available
135129
actuators.torque = float(steer)
136130
actuators.steeringAngleDeg = float(steeringAngleDeg)

selfdrive/controls/lib/latcontrol.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def __init__(self, CP, CI):
1515
self.steer_max = 1.0
1616

1717
@abstractmethod
18-
def update(self, active, CS, VM, params, steer_limited_by_safety, desired_curvature, curvature_limited):
18+
def update(self, active, CS, VM, params, steer_limited_by_safety, desired_curvature, raw_desired_curvature, curvature_limited):
1919
pass
2020

2121
def reset(self):

selfdrive/controls/lib/latcontrol_angle.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def __init__(self, CP, CI):
1313
self.sat_check_min_speed = 5.
1414
self.use_steer_limited_by_safety = CP.brand == "tesla"
1515

16-
def update(self, active, CS, VM, params, steer_limited_by_safety, desired_curvature, curvature_limited):
16+
def update(self, active, CS, VM, params, steer_limited_by_safety, desired_curvature, raw_desired_curvature, curvature_limited):
1717
angle_log = log.ControlsState.LateralAngleState.new_message()
1818

1919
if not active:

selfdrive/controls/lib/latcontrol_pid.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def __init__(self, CP, CI):
1313
k_f=CP.lateralTuning.pid.kf, pos_limit=self.steer_max, neg_limit=-self.steer_max)
1414
self.get_steer_feedforward = CI.get_steer_feedforward_function()
1515

16-
def update(self, active, CS, VM, params, steer_limited_by_safety, desired_curvature, curvature_limited):
16+
def update(self, active, CS, VM, params, steer_limited_by_safety, desired_curvature, raw_desired_curvature, curvature_limited):
1717
pid_log = log.ControlsState.LateralPIDState.new_message()
1818
pid_log.steeringAngleDeg = float(CS.steeringAngleDeg)
1919
pid_log.steeringRateDeg = float(CS.steeringRateDeg)

0 commit comments

Comments
 (0)