Subaru: LKAS Angle based car safety #1533
Closed
+61
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These cars will start in dashcam mode, hence behind allow_debug. |
4 tasks
jnewb1
force-pushed
the
outback-forester-22-PR
branch
from
3efe28f to
2f8e615
Compare
jnewb1
force-pushed
the
outback-forester-22-PR
branch
from
ba2f9a9 to
f342752
Compare
anything else? |
sshane
reviewed
Oct 24, 2023
Comment on lines
+26
to
+27
| {0., 15., 15.}, | ||
| {5., .8, .8} |
There was a problem hiding this comment.
In the case of wheel speed sensor failure, we made the lower limit not exceed ISO limits at ~75 mph for Ford, does this do that, assuming a standard steering ratio?
There was a problem hiding this comment.
this is taken from nissan which has the same units. have a good way to test this from data? these car's will also only be in dashcam mode
There was a problem hiding this comment.
You can use the vehicle model
Co-authored-by: Shane Smiskol <[email protected]>
…anda into outback-forester-22-PR
|
We've moved the car safety code into opendbc, please rebase and re-open your PR there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have so far verified that the 2022 forester and 23 outback use an angle-request based LKAS message.
22 forester is similar to gen1, where everything we care about is on bus0/2
23 outback is similar to gen2, where some messages are on bus1