Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safety: don't silently skip classes with missing abstract methods #2154

Closed
wants to merge 2 commits into from
Closed

safety: don't silently skip classes with missing abstract methods #2154

wants to merge 2 commits into from
+8 −0

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Feb 17, 2025 •
edited
Loading

@adeebshihadeh did you know pytest does this?? unittest.main() catches these and throws a TypeError, but pytest just skips the class. can't believe this hasn't happened yet, just hit it in: #2036

TypeError: Can't instantiate abstract class TestTeslaLongitudinalSafety without an implementation for abstract method '_accel_msg'

@sshane
Copy link
Contributor Author

sshane commented Feb 20, 2025

We've moved the car safety code into opendbc, please rebase and re-open your PR there!

@sshane sshane closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sshane