Migrate action to run oxlint instead of eslint by geoffharcourt · Pull Request #1 · commonlit/action-eslint

geoffharcourt · 2026-04-22T13:09:20Z

Summary

Breaking rewrite of this composite action to run oxlint through reviewdog instead of eslint.

Replaces the bundled eslint-formatter-rdjson with a small Node converter (oxlint-to-rdjsonl.js) that turns oxlint --format=json into rdjsonl lines for reviewdog -f=rdjsonl.
Renames input eslint_flags → oxlint_flags; drops node_options (no-op for a Rust binary); tool_name default becomes oxlint.
Deletes eslint-formatter-rdjson/, the repo-root .eslintrc.js / package.json / package-lock.json, and the npm-publish workflow (nothing to publish).
Test fixtures in testdata/ and test-subproject/ updated so oxlint produces deterministic diagnostics.
Design and implementation plan committed under docs/superpowers/.

35 converter unit tests pass (node --test oxlint-to-rdjsonl.test.js). End-to-end smoke-tested against oxlint 1.61.0.

Breaking changes for consumers

Must depend on oxlint, not eslint.
eslint_flags → oxlint_flags.
node_options removed.

A short "Migrating from action-eslint" section was added to the README.

Test Plan

test workflow runs node --test oxlint-to-rdjsonl.test.js and is green.
reviewdog workflow exercises the action across Node 18/20/22 against testdata/ and test-subproject/sub-testdata/; annotations appear on this PR.
Manual: clone locally, run oxlint --format=json testdata/ | node oxlint-to-rdjsonl.js and confirm rdjsonl output.

🤖 Generated with Claude Code

In-place rewrite of the action-eslint composite action to run oxlint through reviewdog instead of eslint. Captures input renames, the new oxlint→rdjsonl converter, file additions/deletions, and testing plan. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Twenty bite-sized tasks covering: TDD of the JSON→rdjsonl converter, action.yml/script.sh rewrite, deletion of the bundled eslint formatter and repo-root eslint detritus, testdata/test-subproject fixture updates, workflow audit (test.yml rewrite, reviewdog.yml rename, npm-publish.yml deletion), and README rewrite with migration callout. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Validated against oxlint 1.61.0: the output is an object wrapping the diagnostics array (`{"diagnostics": [...], "number_of_files": N, ...}`), not a bare array as the initial spec assumed. Bare arrays still parse for forward-compatibility. Cache file reads so multi-diagnostic files aren't re-read per diagnostic. Spec updated to reflect the real shape. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…ptions Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Smoke-tested against oxlint 1.61.0: empty.js emits no diagnostics; error.js fires no-var + no-unused-vars; test.js fires no-var + no-empty (with a multi-line span). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Needed a subproject-local .oxlintrc.json to shadow the repo-root config's ignorePatterns (which include test-subproject/) — otherwise oxlint considers every subproject file ignored when invoked inside the subproject. Existing sub-testdata/test.js already fires no-var, no-unused-vars, and for-direction under oxlint defaults, so the JS fixture is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

github-actions · 2026-04-22T13:09:40Z

@@ -1 +1 @@
-🐶 // test for unexpected character
+var unusedVar = 1;


🚫 [oxlint] <no-unused-vars> _{reported by reviewdog 🐶}
Variable 'unusedVar' is declared but never used. Unused variables should start with a '_'.

The errors here are duplicated because the workflow tests all three styles of Reviewdog comments. I've confirmed it only reports once per issue on repo code.

github-actions · 2026-04-22T13:09:40Z

@@ -1 +1 @@
-🐶 // test for unexpected character
+var unusedVar = 1;


🚫 [oxlint] <no-var> _{reported by reviewdog 🐶}
Unexpected var, use let or const instead.

github-actions · 2026-04-22T13:09:40Z

+  for (var i = 0; i < 10; i++) {
  }


⚠️ [oxlint] <no-empty> _{reported by reviewdog 🐶}
Unexpected empty block statements

github-actions · 2026-04-22T13:09:40Z

-    var a;var b;//comment
-    console.log(i);
+function sample() {
+  for (var i = 0; i < 10; i++) {


🚫 [oxlint] <no-var> _{reported by reviewdog 🐶}
Unexpected var, use let or const instead.

socket-security · 2026-04-22T13:09:47Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	oxlint@1.61.0

View full report

Previously the action always went through `npx --no-install -c 'oxlint --version'` to detect oxlint, then fell back to `npm install` if that check failed. This broke two pnpm/monorepo cases: 1. pnpm's symlink + workspace:* resolution can make the npx check return non-zero even when oxlint is present. 2. Falling back to `npm install` fails with EUNSUPPORTEDPROTOCOL on any `workspace:*` dep. Now the script resolves oxlint by preference: - binary on PATH -> use directly - ./node_modules/.bin/oxlint -> use directly - neither -> `npm install` as before (still fails on pnpm, but the consumer can opt out by installing oxlint themselves beforehand) Invocation goes through the resolved path; `npx` is only used as a last resort after the install step. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

geoffharcourt · 2026-04-22T13:57:46Z

@@ -0,0 +1,147 @@
+'use strict';


This is a port of the test output formatter that Reviewdog used for ESLint. It's been modified to work for Oxlint's JSON output and tested against real results.

geoffharcourt · 2026-04-22T13:58:40Z

 jobs:
-  eslint:
-    name: runner / eslint
+  oxlint:


This action is used for testing, it's not the actual action that gets run in repo use.

geoffharcourt · 2026-04-22T14:00:08Z

@@ -1,5 +1,5 @@
-name: 'Run eslint with reviewdog'
-description: '🐶 Run eslint with reviewdog on pull requests to improve code review experience.'
+name: 'Run oxlint with reviewdog'


This is the actual production action definition.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

geoffharcourt · 2026-04-22T14:02:29Z

+# project has no oxlint on PATH and no ./node_modules/.bin/oxlint — this
+# avoids breaking pnpm / yarn / monorepo setups where `npm install` would
+# reject workspace protocols.
+if command -v oxlint >/dev/null 2>&1; then


Use the locally-installed oxlint when possible. Removes the need to work with the repo's specific npm/yarn/pnpm setup.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

… two examples Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

geoffharcourt · 2026-06-18T16:24:08Z

Closing for now, we'll return.

geoffharcourt and others added 22 commits April 21, 2026 22:22

feat(converter): scaffold module with severity mapping

8936ddf

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

feat(converter): extract rule code from plugin(rule) format

fbb468a

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

feat(converter): byte-offset to line/column for single-line input

cfe9aca

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

test(converter): cover multi-line, boundary, and UTF-8 offset cases

64d0314

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

feat(converter): transform one oxlint diagnostic to rdjsonl

9a762bc

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

test(converter): edge cases for convertDiagnostic

4df1c64

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

feat(converter): convert a list of diagnostics

d14d68b

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

feat(converter): CLI entrypoint reading stdin, writing rdjsonl

b490a68

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

feat(action): rename inputs eslint_flags -> oxlint_flags, drop node_o…

7f18352

…ptions Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

feat(action): swap eslint pipeline for oxlint + rdjsonl converter

e34d401

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

chore: remove bundled eslint-formatter-rdjson

ceb1134

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

chore: remove repo-root eslint config and package manifest

44030c3

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

chore: add repo-root oxlint config for test fixtures

789c2c8

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

ci: run converter unit tests via node --test

0853d22

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

ci(reviewdog): exercise action with oxlint across node matrix

b70384a

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

ci: remove npm-publish workflow (no npm package to publish)

5edd138

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

docs: rewrite README for oxlint

87e917b

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

github-actions Bot reviewed Apr 22, 2026

View reviewed changes

geoffharcourt and others added 2 commits April 22, 2026 09:29

chore: remove superpowers specs and plans

fbff263

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

geoffharcourt commented Apr 22, 2026

View reviewed changes

chore(action): update author to credit fork lineage

dbeb439

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

docs: remove badges pointing to upstream workflows

9bb3b95

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

geoffharcourt commented Apr 22, 2026

View reviewed changes

geoffharcourt and others added 2 commits April 22, 2026 10:03

docs: point usage examples at commonlit/action-eslint

3915180

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

docs: restore pinned SHAs on actions/checkout and setup-node in first…

eb5c587

… two examples Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

geoffharcourt closed this Jun 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate action to run oxlint instead of eslint#1

Migrate action to run oxlint instead of eslint#1
geoffharcourt wants to merge 28 commits into
masterfrom
oxlint-migration

geoffharcourt commented Apr 22, 2026

Uh oh!

github-actions Bot Apr 22, 2026

Uh oh!

geoffharcourt Apr 22, 2026

Uh oh!

github-actions Bot Apr 22, 2026

Uh oh!

github-actions Bot Apr 22, 2026

Uh oh!

github-actions Bot Apr 22, 2026

Uh oh!

socket-security Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

geoffharcourt Apr 22, 2026

Uh oh!

geoffharcourt Apr 22, 2026

Uh oh!

geoffharcourt Apr 22, 2026

Uh oh!

geoffharcourt Apr 22, 2026

Uh oh!

geoffharcourt commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		@@ -1 +1 @@
		🐶 // test for unexpected character
		var unusedVar = 1;

Uh oh!

Conversation

geoffharcourt commented Apr 22, 2026

Summary

Breaking changes for consumers

Test Plan

Uh oh!

github-actions Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

geoffharcourt Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

socket-security Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geoffharcourt Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

geoffharcourt Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

geoffharcourt Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

geoffharcourt Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

geoffharcourt commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

socket-security Bot commented Apr 22, 2026 •

edited

Loading