forked from reviewdog/action-eslint
-
Notifications
You must be signed in to change notification settings - Fork 0
Migrate action to run oxlint instead of eslint #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 23 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
91c89de
Add design spec for oxlint migration
geoffharcourt dc3fbc1
Add implementation plan for oxlint migration
geoffharcourt 8936ddf
feat(converter): scaffold module with severity mapping
geoffharcourt fbb468a
feat(converter): extract rule code from plugin(rule) format
geoffharcourt cfe9aca
feat(converter): byte-offset to line/column for single-line input
geoffharcourt 64d0314
test(converter): cover multi-line, boundary, and UTF-8 offset cases
geoffharcourt 9a762bc
feat(converter): transform one oxlint diagnostic to rdjsonl
geoffharcourt 4df1c64
test(converter): edge cases for convertDiagnostic
geoffharcourt d14d68b
feat(converter): convert a list of diagnostics
geoffharcourt b490a68
feat(converter): CLI entrypoint reading stdin, writing rdjsonl
geoffharcourt 2605c6c
fix(converter): accept oxlint's real JSON shape, cache file reads
geoffharcourt 7f18352
feat(action): rename inputs eslint_flags -> oxlint_flags, drop node_o…
geoffharcourt e34d401
feat(action): swap eslint pipeline for oxlint + rdjsonl converter
geoffharcourt ceb1134
chore: remove bundled eslint-formatter-rdjson
geoffharcourt 44030c3
chore: remove repo-root eslint config and package manifest
geoffharcourt 789c2c8
chore: add repo-root oxlint config for test fixtures
geoffharcourt 68ed96e
test: rewrite testdata fixtures for oxlint's default rules
geoffharcourt 2d56598
test(subproject): migrate to oxlint, regenerate lockfile
geoffharcourt 0853d22
ci: run converter unit tests via node --test
geoffharcourt b70384a
ci(reviewdog): exercise action with oxlint across node matrix
geoffharcourt 5edd138
ci: remove npm-publish workflow (no npm package to publish)
geoffharcourt 87e917b
docs: rewrite README for oxlint
geoffharcourt c6df9ef
fix(action): skip npm install when oxlint is already available
geoffharcourt fbff263
chore: remove superpowers specs and plans
geoffharcourt dbeb439
chore(action): update author to credit fork lineage
geoffharcourt 9bb3b95
docs: remove badges pointing to upstream workflows
geoffharcourt 3915180
docs: point usage examples at commonlit/action-eslint
geoffharcourt eb5c587
docs: restore pinned SHAs on actions/checkout and setup-node in first…
geoffharcourt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "$schema": "https://raw.githubusercontent.com/oxc-project/oxc/main/npm/oxlint/configuration_schema.json", | ||
| "rules": { | ||
| "no-unused-vars": "error", | ||
| "no-var": "error", | ||
| "no-empty": "warn" | ||
| }, | ||
| "ignorePatterns": [ | ||
| "test-subproject/", | ||
| "node_modules/" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| name: 'Run eslint with reviewdog' | ||
| description: '🐶 Run eslint with reviewdog on pull requests to improve code review experience.' | ||
| name: 'Run oxlint with reviewdog' | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the actual production action definition. |
||
| description: '🐶 Run oxlint with reviewdog on pull requests to improve code review experience.' | ||
| author: 'haya14busa (reviewdog)' | ||
| inputs: | ||
| github_token: | ||
|
|
@@ -41,42 +41,35 @@ inputs: | |
| description: 'Additional reviewdog flags' | ||
| required: false | ||
| default: '' | ||
| eslint_flags: | ||
| description: "flags and args of eslint command. Default: '.'" | ||
| oxlint_flags: | ||
| description: "flags and args of oxlint command. Default: '.'" | ||
| required: false | ||
| default: '.' | ||
| workdir: | ||
| description: "The directory from which to look for and run eslint. Default '.'" | ||
| description: "The directory from which to look for and run oxlint. Default '.'" | ||
| required: false | ||
| default: '.' | ||
| tool_name: | ||
| description: 'Tool name to use for reviewdog reporter' | ||
| required: false | ||
| default: 'eslint' | ||
| node_options: | ||
| description: 'NODE_OPTIONS for running eslint' | ||
| required: false | ||
| default: '' | ||
| default: 'oxlint' | ||
| runs: | ||
| using: 'composite' | ||
| steps: | ||
| - run: $GITHUB_ACTION_PATH/script.sh | ||
| shell: bash | ||
| env: | ||
| REVIEWDOG_VERSION: v0.21.0 | ||
| # INPUT_<VARIABLE_NAME> is not available in Composite run steps | ||
| # https://github.community/t/input-variable-name-is-not-available-in-composite-run-steps/127611 | ||
| INPUT_GITHUB_TOKEN: ${{ inputs.github_token }} | ||
| INPUT_LEVEL: ${{ inputs.level }} | ||
| INPUT_REPORTER: ${{ inputs.reporter }} | ||
| INPUT_FILTER_MODE: ${{ inputs.filter_mode }} | ||
| INPUT_FAIL_LEVEL: ${{ inputs.fail_level }} | ||
| INPUT_FAIL_ON_ERROR: ${{ inputs.fail_on_error }} | ||
| INPUT_REVIEWDOG_FLAGS: ${{ inputs.reviewdog_flags }} | ||
| INPUT_ESLINT_FLAGS: ${{ inputs.eslint_flags }} | ||
| INPUT_OXLINT_FLAGS: ${{ inputs.oxlint_flags }} | ||
| INPUT_WORKDIR: ${{ inputs.workdir }} | ||
| INPUT_TOOL_NAME: ${{ inputs.tool_name }} | ||
| NODE_OPTIONS: ${{ inputs.node_options }} | ||
| branding: | ||
| icon: 'alert-octagon' | ||
| color: 'blue' | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This action is used for testing, it's not the actual action that gets run in repo use.