[runtime/p2p] Use `Buf` / `BufMut` in networking APIs #2558

clabby · 2025-12-18T19:43:35Z

Overview

Alters the core networking APIs to use Buf / BufMut rather than StableBuf. This unlocks passing non-contiguous buffers + vectorized read/write operations.

closes #784

cloudflare-workers-and-pages · 2025-12-18T19:43:58Z

Deploying monorepo with Cloudflare Pages

Latest commit:	`429c414`
Status:	✅ Deploy successful!
Preview URL:	https://0f4be186.monorepo-eu0.pages.dev
Branch Preview URL:	https://cl-vectored-network.monorepo-eu0.pages.dev

View logs

p2p/src/authenticated/lookup/actors/router/ingress.rs

runtime/src/network/tokio.rs

andresilva · 2025-12-22T18:36:38Z

p2p/src/utils/mux.rs

-        buf.put_slice(&message);
-        self.inner.send(buf.freeze(), priority).await
+        self.inner
+            .send(subchannel.encode().chain(message), priority)


runtime/src/network/tokio.rs

p2p/src/authenticated/lookup/actors/router/ingress.rs

andresilva · 2025-12-22T19:09:56Z

stream/src/utils/codec.rs

-    len.write(&mut prefixed_buf);
-    prefixed_buf.extend_from_slice(buf);
-    sink.send(prefixed_buf).await.map_err(Error::SendFailed)
+    let data = len.encode().freeze().chain(buf);


🚀

(this one will actually get vectored)

stream/src/lib.rs

patrick-ogrady · 2026-01-05T16:51:24Z

runtime/src/lib.rs

-        &mut self,
-        buf: impl Into<StableBuf> + Send,
-    ) -> impl Future<Output = Result<StableBuf, Error>> + Send;
+    fn recv(&mut self, buf: impl BufMut + Send) -> impl Future<Output = Result<(), Error>> + Send;


Should we add a trait alias for BufMut + Send

I don't think so; It's only used 7 times in the whole codebase & is a bit more clear to have inline.

patrick-ogrady

Left my changes here: #2706

andresilva

Maybe we could have:

Encode::encode_mut() -> BytesMut
Encode::encode() -> Bytes { self.encode_mut().freeze() }

This would remove all of the encode().freeze() noise and make sure we actually freeze as much as we can (I think we are missing a lot of places?). We probably wouldn't use encode_mut() anywhere right now (but not sure about this, should be trivial anyway).

fmt

codecov · 2026-01-06T17:15:43Z

Codecov Report

❌ Patch coverage is 99.72376% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.81%. Comparing base (ff8fefb) to head (429c414).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...rc/authenticated/discovery/actors/tracker/actor.rs	0.00%	1 Missing ⚠️

@@            Coverage Diff             @@
##             main    #2558      +/-   ##
==========================================
- Coverage   92.82%   92.81%   -0.01%     
==========================================
  Files         361      361              
  Lines      106797   106800       +3     
==========================================
- Hits        99134    99129       -5     
- Misses       7663     7671       +8

Files with missing lines	Coverage Δ
codec/src/codec.rs	`100.00% <100.00%> (ø)`
codec/src/types/hash_map.rs	`100.00% <100.00%> (ø)`
codec/src/types/hash_set.rs	`100.00% <100.00%> (ø)`
collector/src/p2p/mocks/sender.rs	`100.00% <100.00%> (ø)`
collector/src/p2p/mod.rs	`98.97% <100.00%> (ø)`
consensus/src/aggregation/types.rs	`97.40% <100.00%> (ø)`
consensus/src/marshal/actor.rs	`92.86% <100.00%> (ø)`
consensus/src/ordered_broadcast/engine.rs	`85.95% <100.00%> (ø)`
consensus/src/simplex/actors/batcher/mod.rs	`97.45% <100.00%> (-0.01%)`	⬇️
consensus/src/simplex/actors/resolver/actor.rs	`79.74% <100.00%> (ø)`
... and 49 more

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8fefb...429c414. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

clabby self-assigned this Dec 18, 2025

clabby added the breaking-api This PR modifies the public interface of a function. label Dec 18, 2025

clabby force-pushed the cl/vectored-network branch from 3ceff94 to c376e34 Compare December 18, 2025 19:51

clabby mentioned this pull request Dec 18, 2025

[runtime] Vectorized sink #2518

Closed

clabby changed the title ~~[runtime] Buffered networking APIs~~ [runtime/p2p] Buffered networking APIs Dec 18, 2025

clabby commented Dec 18, 2025

View reviewed changes

p2p/src/authenticated/lookup/actors/router/ingress.rs Show resolved Hide resolved

clabby marked this pull request as ready for review December 18, 2025 20:23

clabby force-pushed the cl/vectored-network branch 3 times, most recently from 3106904 to d29b10d Compare December 19, 2025 18:47

clabby mentioned this pull request Dec 20, 2025

[runtime/network/tokio] add read buffering #2593

Closed

clabby force-pushed the cl/vectored-network branch 3 times, most recently from 233a1d2 to 8f6dfef Compare December 22, 2025 15:19

cursor bot reviewed Dec 22, 2025

View reviewed changes

runtime/src/network/tokio.rs Show resolved Hide resolved

clabby force-pushed the cl/vectored-network branch from 8f6dfef to b7faedd Compare December 22, 2025 15:28

clabby changed the title ~~[runtime/p2p] Buffered networking APIs~~ [runtime/p2p] Use Buf / BufMut in networking APIs Dec 22, 2025

clabby force-pushed the cl/vectored-network branch from b7faedd to 957c3ae Compare December 22, 2025 15:37

andresilva previously approved these changes Dec 22, 2025

View reviewed changes

andresilva reviewed Dec 22, 2025

View reviewed changes

stream/src/lib.rs Show resolved Hide resolved

clabby dismissed andresilva’s stale review via b4094d9 December 22, 2025 19:49

clabby force-pushed the cl/vectored-network branch 2 times, most recently from de1b2d6 to ba0fb8a Compare December 26, 2025 16:06

clabby added this to Tracker Jan 5, 2026

clabby moved this to Ready for Review in Tracker Jan 5, 2026

patrick-ogrady mentioned this pull request Jan 5, 2026

[storage] Take Advantage of impl Buf on Runtime Blob #2554

Open

patrick-ogrady reviewed Jan 5, 2026

View reviewed changes

clabby force-pushed the cl/vectored-network branch from ba0fb8a to e7f0fd7 Compare January 5, 2026 20:58

clabby force-pushed the cl/vectored-network branch 3 times, most recently from 410dcfe to 14c4508 Compare January 5, 2026 22:07

patrick-ogrady mentioned this pull request Jan 6, 2026

[runtime] Vectored Network Nits #2706

Merged

patrick-ogrady reviewed Jan 6, 2026

View reviewed changes

clabby requested a review from patrick-ogrady January 6, 2026 03:26

andresilva requested changes Jan 6, 2026

View reviewed changes

clabby and others added 13 commits January 6, 2026 10:28

[runtime] Buffered networking APIs

c353df9

[runtime] Buffered stream

294f73a

Chain bytes in send_frame

34a8a4d

io_uring stream - copy for now

bf4b9a8

fmt

use an intermediate buffer in audited

b498aa1

review

2d60290

propagate changes to p2p

fb667f6

mux simplification

dd57977

update new tests

451578b

Use impl Buf on stream::Sender::send

48ccd33

Update stream EOF error in tokio runtime

c2f9343

update new tests

b6cb441

[runtime] Vectored Network Nits (#2706)

00f656c

clabby force-pushed the cl/vectored-network branch from 2b71082 to 8af9de0 Compare January 6, 2026 15:42

Add Encode::encode_mut & Encode::encode -> Bytes

429c414

clabby force-pushed the cl/vectored-network branch from 8af9de0 to 429c414 Compare January 6, 2026 15:43

andresilva approved these changes Jan 6, 2026

View reviewed changes

patrick-ogrady approved these changes Jan 6, 2026

View reviewed changes

patrick-ogrady merged commit fcb1f0f into main Jan 6, 2026
127 checks passed

patrick-ogrady deleted the cl/vectored-network branch January 6, 2026 17:14

github-project-automation bot moved this from Ready for Review to Done in Tracker Jan 6, 2026

andresilva mentioned this pull request Jan 6, 2026

[p2p / stream / runtime] Use bytes::Buf trait instead of bytes::Bytes type when sending messages #1434

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[runtime/p2p] Use `Buf` / `BufMut` in networking APIs #2558

[runtime/p2p] Use `Buf` / `BufMut` in networking APIs #2558

Uh oh!

clabby commented Dec 18, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

andresilva Dec 22, 2025

Uh oh!

Uh oh!

Uh oh!

andresilva Dec 22, 2025

Uh oh!

Uh oh!

patrick-ogrady Jan 5, 2026

Uh oh!

clabby Jan 5, 2026

Uh oh!

patrick-ogrady left a comment

Uh oh!

andresilva left a comment •

edited

Loading

Uh oh!

Uh oh!

codecov bot commented Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[runtime/p2p] Use Buf / BufMut in networking APIs #2558

[runtime/p2p] Use Buf / BufMut in networking APIs #2558

Uh oh!

Conversation

clabby commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Uh oh!

cloudflare-workers-and-pages bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying monorepo with Cloudflare Pages

Uh oh!

Uh oh!

Uh oh!

andresilva Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

andresilva Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

patrick-ogrady Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

clabby Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

patrick-ogrady left a comment

Choose a reason for hiding this comment

Uh oh!

andresilva left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Jan 6, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[runtime/p2p] Use `Buf` / `BufMut` in networking APIs #2558

[runtime/p2p] Use `Buf` / `BufMut` in networking APIs #2558

clabby commented Dec 18, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Dec 18, 2025 •

edited

Loading

andresilva left a comment •

edited

Loading