[runtime] Vectored Network Nits #2706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | 5eb8fc2 | Jan 06 2026, 01:48 AM |
patrick-ogrady
commented
Jan 6, 2026
| let subchannel = UInt(self.subchannel.expect("subchannel not set")); | ||
| self.inner | ||
| .send(subchannel.encode().chain(message), priority) | ||
| .send(subchannel.encode().freeze().chain(message), priority) |
Contributor
Author
There was a problem hiding this comment.
This shouldn't really cause any issues but better safe than sorry
clabby
approved these changes
Jan 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cl/vectored-network #2706 +/- ##
====================================================
Coverage 92.82% 92.82%
====================================================
Files 361 361
Lines 106286 106286
====================================================
Hits 98656 98656
Misses 7630 7630
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
clabby
pushed a commit
that referenced
this pull request
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2558