[runtime] Vectored Network Nits

consensus/src/ordered_broadcast/engine.rs

@@ -838,7 +838,7 @@ impl<
         node_sender
             .send(
                 Recipients::Some(validators.iter().cloned().collect()),
-                node.encode(),
+                node.encode().freeze(),
                 self.priority_proposals,
             )
             .await

examples/sync/src/bin/server.rs

@@ -346,7 +346,7 @@ where
         outgoing = response_receiver.next() => {
             if let Some(response) = outgoing {
                 // We have a response to send to the client.
-                let response_data = response.encode();
+                let response_data = response.encode().freeze();
                 if let Err(err) = send_frame(&mut sink, response_data, MAX_MESSAGE_SIZE).await {
                     info!(client_addr = %client_addr, ?err, "send failed (client likely disconnected)");
                     state.error_counter.inc();

examples/sync/src/net/io.rs

@@ -45,7 +45,7 @@ async fn run_loop<E, Si, St, M>(
                 Some(Request { request, response_tx }) => {
                     let request_id = request.request_id();
                     pending_requests.insert(request_id, response_tx);
-                    let data = request.encode();
+                    let data = request.encode().freeze();
                     if let Err(e) = send_frame(&mut sink, data, MAX_MESSAGE_SIZE).await {
                         if let Some(sender) = pending_requests.remove(&request_id) {
                             let _ = sender.send(Err(Error::Network(e)));

p2p/src/utils/mux.rs

@@ -359,7 +359,7 @@ impl<'a, S: Sender> CheckedSender for CheckedGlobalSender<'a, S> {
     ) -> Result<Vec<Self::PublicKey>, Self::Error> {
         let subchannel = UInt(self.subchannel.expect("subchannel not set"));
         self.inner
-            .send(subchannel.encode().chain(message), priority)
+            .send(subchannel.encode().freeze().chain(message), priority)
             .await
     }
 }

runtime/src/network/iouring.rs

@@ -242,8 +242,7 @@ impl Sink {
 
 impl crate::Sink for Sink {
     async fn send(&mut self, mut msg: impl Buf + Send) -> Result<(), crate::Error> {
-        // For now, collect the message into a stable buffer. In the future,
-        // we could optimize this by using writev w/ a keepalive for the iovecs.
+        // TODO(#2705): Use writev to avoid this copy.
         let mut msg: StableBuf = {
             let buf = msg.copy_to_bytes(msg.remaining());
             BytesMut::from(buf).into()