Skip to content

[consensus/simplex] move metric update after validation

cf2cc46
Select commit
Loading
Failed to load commit list.
Merged

[consensus/simplex] Add Voting Metrics #2708

[consensus/simplex] move metric update after validation
cf2cc46
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 6, 2026 in 1s

92.82% (+0.00%) compared to fcb1f0f

View this Pull Request on Codecov

92.82% (+0.00%) compared to fcb1f0f

Details

Codecov Report

❌ Patch coverage is 95.60440% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.82%. Comparing base (fcb1f0f) to head (cf2cc46).

Files with missing lines Patch % Lines
consensus/src/simplex/actors/batcher/mod.rs 94.93% 8 Missing ⚠️
@@           Coverage Diff            @@
##             main    #2708    +/-   ##
========================================
  Coverage   92.81%   92.82%            
========================================
  Files         361      361            
  Lines      107038   107218   +180     
========================================
+ Hits        99352    99527   +175     
- Misses       7686     7691     +5     
Files with missing lines Coverage Δ
consensus/src/simplex/actors/batcher/actor.rs 94.75% <100.00%> (+0.21%) ⬆️
consensus/src/simplex/metrics.rs 100.00% <100.00%> (ø)
runtime/src/telemetry/metrics/status.rs 100.00% <100.00%> (ø)
consensus/src/simplex/actors/batcher/mod.rs 97.07% <94.93%> (-0.38%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcb1f0f...cf2cc46. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.