-
Notifications
You must be signed in to change notification settings - Fork 171
[runtime, storage] move to crc32c #2740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | 9bfaf83 | Jan 08 2026, 12:32 PM |
Deploying monorepo with
|
| Latest commit: |
9bfaf83
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://189316aa.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://andre-crc32c.monorepo-eu0.pages.dev |
1267841 to
d973254
Compare
82ff196 to
8473945
Compare
patrick-ogrady
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits
| /// | ||
| /// Returns the checksum as a `u32` directly. | ||
| #[inline] | ||
| pub fn checksum(data: &[u8]) -> u32 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call this hash()?
May be implicitly defined on Hasher, I forgot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah hash is already defined in Hasher and returns Digest, this one avoids the roundtrip between array and u32.
patrick-ogrady
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #2740 +/- ##
==========================================
- Coverage 93.21% 93.20% -0.02%
==========================================
Files 371 372 +1
Lines 113204 113359 +155
==========================================
+ Hits 105525 105655 +130
- Misses 7679 7704 +25
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Depends on #2667.
Replaces #2591.
Closes #2589.