Skip to content

Conversation

@andresilva
Copy link
Collaborator

@andresilva andresilva commented Jan 8, 2026

Depends on #2667.
Replaces #2591.
Closes #2589.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 8, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp 9bfaf83 Jan 08 2026, 12:32 PM

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 8, 2026

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9bfaf83
Status: ✅  Deploy successful!
Preview URL: https://189316aa.monorepo-eu0.pages.dev
Branch Preview URL: https://andre-crc32c.monorepo-eu0.pages.dev

View logs

@andresilva andresilva added the breaking-format This PR modifies codec and/or storage formats. label Jan 8, 2026
Copy link
Contributor

@patrick-ogrady patrick-ogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

///
/// Returns the checksum as a `u32` directly.
#[inline]
pub fn checksum(data: &[u8]) -> u32 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call this hash()?

May be implicitly defined on Hasher, I forgot

Copy link
Collaborator Author

@andresilva andresilva Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah hash is already defined in Hasher and returns Digest, this one avoids the roundtrip between array and u32.

patrick-ogrady
patrick-ogrady previously approved these changes Jan 8, 2026
Copy link
Contributor

@patrick-ogrady patrick-ogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

patrick-ogrady
patrick-ogrady previously approved these changes Jan 8, 2026
patrick-ogrady
patrick-ogrady previously approved these changes Jan 8, 2026
@patrick-ogrady patrick-ogrady added this pull request to the merge queue Jan 8, 2026
Merged via the queue into main with commit 5ca1fb0 Jan 8, 2026
129 of 130 checks passed
@patrick-ogrady patrick-ogrady deleted the andre/crc32c branch January 8, 2026 14:24
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 87.98077% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.20%. Comparing base (57ddd8c) to head (9bfaf83).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cryptography/src/crc32/mod.rs 84.31% 24 Missing ⚠️
runtime/src/utils/buffer/pool/read.rs 83.33% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main    #2740      +/-   ##
==========================================
- Coverage   93.21%   93.20%   -0.02%     
==========================================
  Files         371      372       +1     
  Lines      113204   113359     +155     
==========================================
+ Hits       105525   105655     +130     
- Misses       7679     7704      +25     
Files with missing lines Coverage Δ
cryptography/src/blake3/mod.rs 75.64% <ø> (ø)
cryptography/src/lib.rs 100.00% <ø> (ø)
cryptography/src/sha256/mod.rs 92.20% <ø> (ø)
runtime/src/utils/buffer/pool/append.rs 96.29% <100.00%> (ø)
runtime/src/utils/buffer/pool/mod.rs 97.37% <100.00%> (ø)
runtime/src/utils/buffer/pool/page_cache.rs 96.10% <100.00%> (ø)
storage/src/freezer/mod.rs 99.71% <100.00%> (+<0.01%) ⬆️
storage/src/freezer/storage.rs 90.04% <100.00%> (ø)
storage/src/journal/segmented/glob.rs 96.32% <100.00%> (ø)
storage/src/journal/segmented/oversized.rs 97.72% <100.00%> (ø)
... and 5 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ddd8c...9bfaf83. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-format This PR modifies codec and/or storage formats.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[storage] Move to CRC-32C

4 participants