[treewide] rustfmt over select!

[andresilva]

I added support for select! and select_loop! to rustfmt. This is the result 😬.

andresilva/rustfmt@e20ec8b

Depends on #2671.

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Updated (UTC)
✅ Deployment successful! View logs	commonware-mcp	74b528c	Jan 28 2026, 06:13 PM

[cloudflare-workers-and-pages]

Deploying monorepo with    Cloudflare Pages

Latest commit:	74b528c
Status:	✅  Deploy successful!
Preview URL:	https://393b61f2.monorepo-eu0.pages.dev
Branch Preview URL:	https://andre-rustfmt-select.monorepo-eu0.pages.dev

View logs

[patrick-ogrady]

I added support for select! and select_loop! to rustfmt. This is the result 😬.

andresilva/rustfmt@e20ec8b

So, the idea is to just run it locally once in a while? Can we store a patch in CI and apply it to the latest rustfmt or something to catch in CI?

[andresilva]

I think running this in CI would be ideal, not sure how fast that patch will rot, so might be best to just build that rustfmt binary once and download it in CI? Most likely in a separate format step, so that we keep running the main format step with the up-to-date rustfmt. WDYT? We can then update the patch and re-build the binary every once in a while.

[codecov]

Codecov Report

❌ Patch coverage is 82.38994% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.12%. Comparing base (43b38b3) to head (74b528c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
consensus/src/simplex/actors/voter/mod.rs	71.79%	22 Missing ⚠️
p2p/src/authenticated/lookup/actors/peer/actor.rs	69.76%	13 Missing ⚠️
...p/src/authenticated/discovery/actors/peer/actor.rs	82.45%	10 Missing ⚠️
p2p/src/authenticated/discovery/mod.rs	11.11%	8 Missing ⚠️
p2p/src/authenticated/lookup/mod.rs	11.11%	8 Missing ⚠️
consensus/src/aggregation/engine.rs	57.14%	6 Missing ⚠️
consensus/src/simplex/actors/batcher/mod.rs	33.33%	4 Missing ⚠️
...p/src/authenticated/lookup/actors/tracker/actor.rs	0.00%	4 Missing ⚠️
resolver/src/p2p/mod.rs	50.00%	4 Missing ⚠️
consensus/src/ordered_broadcast/mod.rs	50.00%	1 Missing ⚠️
... and 4 more

@@            Coverage Diff             @@
##             main    #2927      +/-   ##
==========================================
- Coverage   92.14%   92.12%   -0.03%     
==========================================
  Files         389      389              
  Lines      123691   123812     +121     
==========================================
+ Hits       113980   114066      +86     
- Misses       9711     9746      +35     

Files with missing lines	Coverage Δ
broadcast/src/buffered/engine.rs	94.30% <100.00%> (+0.31%)	⬆️
collector/src/p2p/engine.rs	85.36% <100.00%> (-0.47%)	⬇️
collector/src/p2p/mod.rs	98.82% <100.00%> (ø)
consensus/src/marshal/actor.rs	93.52% <100.00%> (+0.33%)	⬆️
consensus/src/marshal/mod.rs	94.25% <100.00%> (+0.05%)	⬆️
consensus/src/ordered_broadcast/engine.rs	86.61% <100.00%> (+0.32%)	⬆️
consensus/src/simplex/actors/batcher/actor.rs	94.40% <100.00%> (-0.40%)	⬇️
consensus/src/simplex/actors/resolver/actor.rs	80.24% <100.00%> (+0.37%)	⬆️
consensus/src/simplex/actors/voter/actor.rs	97.16% <100.00%> (+0.03%)	⬆️
consensus/src/simplex/mocks/application.rs	94.97% <100.00%> (+0.07%)	⬆️
... and 29 more

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b38b3...74b528c. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.