Skip to content

[macros] add refutable pattern support with else clause to select_loop! #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrick-ogrady merged 9 commits into from
Feb 1, 2026

[workspace] migrate more cases

7dd4a27
Select commit
Loading
Failed to load commit list.
Merged

[macros] add refutable pattern support with else clause to select_loop! #2933

[workspace] migrate more cases
7dd4a27
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 1, 2026 in 1s

93.12% (+0.00%) compared to 7edcd44

View this Pull Request on Codecov

93.12% (+0.00%) compared to 7edcd44

Details

Codecov Report

❌ Patch coverage is 80.51282% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.12%. Comparing base (7edcd44) to head (7dd4a27).

Files with missing lines Patch % Lines
macros/impl/src/lib.rs 64.51% 11 Missing ⚠️
p2p/src/authenticated/lookup/actors/peer/actor.rs 25.00% 3 Missing ⚠️
consensus/src/aggregation/engine.rs 33.33% 2 Missing ⚠️
consensus/src/ordered_broadcast/engine.rs 33.33% 2 Missing ⚠️
...src/authenticated/discovery/actors/router/actor.rs 33.33% 2 Missing ⚠️
...rc/authenticated/discovery/actors/spawner/actor.rs 33.33% 2 Missing ⚠️
...rc/authenticated/discovery/actors/tracker/actor.rs 33.33% 2 Missing ⚠️
p2p/src/authenticated/lookup/actors/listener.rs 50.00% 2 Missing ⚠️
...2p/src/authenticated/lookup/actors/router/actor.rs 33.33% 2 Missing ⚠️
...p/src/authenticated/lookup/actors/spawner/actor.rs 33.33% 2 Missing ⚠️
... and 6 more 
@@           Coverage Diff           @@
##             main    #2933   +/-   ##
=======================================
  Coverage   93.12%   93.12%           
=======================================
  Files         389      389           
  Lines      122643   122619   -24     
=======================================
- Hits       114215   114193   -22     
+ Misses       8428     8426    -2
Files with missing lines Coverage Δ
broadcast/src/buffered/engine.rs 94.28% <100.00%> (-0.03%) ⬇️
consensus/src/marshal/actor.rs 93.77% <100.00%> (-0.04%) ⬇️
consensus/src/simplex/actors/batcher/actor.rs 95.94% <100.00%> (+0.91%) ⬆️
consensus/src/simplex/actors/resolver/actor.rs 83.22% <100.00%> (+0.83%) ⬆️
consensus/src/simplex/actors/voter/actor.rs 97.77% <100.00%> (-0.02%) ⬇️
p2p/src/authenticated/discovery/mod.rs 99.06% <100.00%> (+0.07%) ⬆️
p2p/src/simulated/network.rs 95.63% <100.00%> (+0.40%) ⬆️
collector/src/p2p/engine.rs 85.71% <96.00%> (+0.34%) ⬆️
consensus/src/simplex/mocks/application.rs 94.38% <66.66%> (-0.59%) ⬇️
...p/src/authenticated/discovery/actors/peer/actor.rs 95.37% <50.00%> (-0.02%) ⬇️
... and 13 more

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7edcd44...7dd4a27. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov