Refactor datasets.py and update corresponding unit tests/tutorial notebook #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… error checks in datasets.py. Update test_datasets.py.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Converting to draft: I will review when the github actions pass, can you mark as "ready for review" when that is the case (let me know if the osf not found problem persists?). Thanks 🙌 |
…instead of subprocess.run().
…s difference test instances access the same file.
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 90.13% 98.66% +8.54%
==========================================
Files 5 5
Lines 243 223 -20
==========================================
+ Hits 219 220 +1
+ Misses 24 3 -21
Continue to review full report at Codecov.
|
ninamiolane
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors
datasets.pyby making the upload/download pipeline consistent. Previously, uploading and downloading used different classes but now all the methods are inOSFProjectclass.Unit tests and tutorial notebook were updated accordingly.
Issue
#74