Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor datasets.py and update corresponding unit tests/tutorial notebook #89

Merged
merged 39 commits into from
May 17, 2022
Merged

Refactor datasets.py and update corresponding unit tests/tutorial notebook #89

merged 39 commits into from
May 17, 2022

Commits on May 10, 2022

  1. Issue #74: Remove OSFUpload class, change Project class name to OSFPr… 

    …oject.
    @bongjinkoo
    bongjinkoo committed May 10, 2022
    Configuration menu
    Copy the full SHA
    85d156a View commit details
    Browse the repository at this point in the history

  2. Issue #74: Add osfclient to environment.yml.

    @bongjinkoo
    bongjinkoo committed May 10, 2022
    Configuration menu
    Copy the full SHA
    3b8aa92 View commit details
    Browse the repository at this point in the history

  3. Issue #74: Update black version in .pre-commit-config.yaml.

    @bongjinkoo
    bongjinkoo committed May 10, 2022
    Configuration menu
    Copy the full SHA
    80866de View commit details
    Browse the repository at this point in the history

Commits on May 13, 2022

  1. Issue #74: Add a delete file function in datasets.py. Add method args… 

    … error checks in datasets.py. Update test_datasets.py.
    @bongjinkoo
    bongjinkoo committed May 13, 2022
    Configuration menu
    Copy the full SHA
    39344f7 View commit details
    Browse the repository at this point in the history

  2. Issue #74: Update errors from ValueError to TypeError in datasets.py

    @bongjinkoo
    bongjinkoo committed May 13, 2022
    Configuration menu
    Copy the full SHA
    f7e9e8f View commit details
    Browse the repository at this point in the history

Commits on May 14, 2022

  1. Issue #74: Add a test_upload file and finish up datasets.py, test_dat… 

    …asets.py.
    @bongjinkoo
    bongjinkoo committed May 14, 2022
    Configuration menu
    Copy the full SHA
    5027232 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2022

  1. Issue #74: Update download_and_upload_with_osf.ipynb.

    @bongjinkoo
    bongjinkoo committed May 15, 2022
    Configuration menu
    Copy the full SHA
    8a7dbb3 View commit details
    Browse the repository at this point in the history

  2. Issue #74: Fix a print string error in test_datasets.py.

    @bongjinkoo
    bongjinkoo committed May 15, 2022
    Configuration menu
    Copy the full SHA
    017d75d View commit details
    Browse the repository at this point in the history

  3. Issue #74: Remove an unnecessary comment in datasets.py.

    @bongjinkoo
    bongjinkoo committed May 15, 2022
    Configuration menu
    Copy the full SHA
    9035d6c View commit details
    Browse the repository at this point in the history

  4. Issue #74: Update environment.yml for osfclient.

    @bongjinkoo
    bongjinkoo committed May 15, 2022
    Configuration menu
    Copy the full SHA
    f0898a8 View commit details
    Browse the repository at this point in the history

  5. Issue #74: Testing unit tests for osfclient.

    @bongjinkoo
    bongjinkoo committed May 15, 2022
    Configuration menu
    Copy the full SHA
    4be65f0 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. Issue #74: Testing test_datasets.py. Using subprocess instead of os.s… 

    …ystem().
    @bongjinkoo
    bongjinkoo committed May 16, 2022
    Configuration menu
    Copy the full SHA
    7f2d9ed View commit details
    Browse the repository at this point in the history

  2. Issue #74: Testing test_datasets.py, using subprocess.run().

    @bongjinkoo
    bongjinkoo committed May 16, 2022
    Configuration menu
    Copy the full SHA
    3cd92d2 View commit details
    Browse the repository at this point in the history

  3. Issue #74: Testing test_datasets.py, add logging.

    @bongjinkoo
    bongjinkoo committed May 16, 2022
    Configuration menu
    Copy the full SHA
    9583821 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. Issue #74: Testing test_datasets.py, update logging.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    32b3ae7 View commit details
    Browse the repository at this point in the history

  2. Issue #74: Testing test_datasets.py, update logging.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    21d3d16 View commit details
    Browse the repository at this point in the history

  3. Issue #74: Testing test_datasets.py, trying a wrong command.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    a0035dd View commit details
    Browse the repository at this point in the history

  4. Issue #74: Testing test_datasets.py.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    753b5fa View commit details
    Browse the repository at this point in the history

  5. Issue #74: Testing test_datasets.py.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    5486fb2 View commit details
    Browse the repository at this point in the history

  6. Issue #74: Testing test_datasets.py.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    73c2852 View commit details
    Browse the repository at this point in the history

  7. Issue #74: Testing test_datasets.py, using subprocess.check_output() … 

    …instead of subprocess.run().
    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    bf15165 View commit details
    Browse the repository at this point in the history

  8. Issue #74: Testing test_datasets.py, using subprocess.run() with stdo… 

    …ut option.
    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    8951bb4 View commit details
    Browse the repository at this point in the history

  9. Issue #74: Testing test_datasets.py, outputting CONDA path.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    b334dfa View commit details
    Browse the repository at this point in the history

  10. Issue #74: Testing test_datasets.py, prefixing CONDA path.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    f521049 View commit details
    Browse the repository at this point in the history

  11. Issue #74: Testing test_datasets.py, prefixing CONDA path.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    d834324 View commit details
    Browse the repository at this point in the history

  12. Issue #74: Testing test_datasets.py, fix test file path.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    6d274c1 View commit details
    Browse the repository at this point in the history

  13. Issue #74: Testing test_datasets.py, fix test file path.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    a5d1045 View commit details
    Browse the repository at this point in the history

  14. Issue #74: Testing test_datasets.py, fix test file path.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    5852042 View commit details
    Browse the repository at this point in the history

  15. Issue #74: Testing test_datasets.py, fix test file path.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    3aab671 View commit details
    Browse the repository at this point in the history

  16. Issue #74: Testing test_datasets.py, fix test file path.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    603fd4e View commit details
    Browse the repository at this point in the history

  17. Issue #74: Testing test_datasets.py, fix test file path.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    da55acb View commit details
    Browse the repository at this point in the history

  18. Issue #74: Testing test_datasets.py, fix test file path.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    d3f3c29 View commit details
    Browse the repository at this point in the history

  19. Issue #74: Testing test_datasets.py, adding --force for osf upload.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    d550e4e View commit details
    Browse the repository at this point in the history

  20. Issue #74: Testing test_datasets.py, randomising the test file name a… 

    …s difference test instances access the same file.
    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    7d6356a View commit details
    Browse the repository at this point in the history

  21. Issue #74: Update test_datasets.py.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    61e6fbc View commit details
    Browse the repository at this point in the history

  22. Issue #74: Update coverage for test_datasets.py.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    9039ec6 View commit details
    Browse the repository at this point in the history

  23. Issue #74: Remove os.system() in test_datasets.py.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    d0a5342 View commit details
    Browse the repository at this point in the history

  24. Issue #74: Add check flag for subprocess in test_datasets.py.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    1ea2739 View commit details
    Browse the repository at this point in the history

  25. Issue #74: Fix a long line in datasets.py.

    @bongjinkoo
    bongjinkoo committed May 17, 2022
    Configuration menu
    Copy the full SHA
    355146b View commit details
    Browse the repository at this point in the history