Skip to content

Conversation

@munrocket
Copy link
Collaborator

@munrocket munrocket commented Jun 10, 2025

  • make only one device and one context
  • remove async in render() and requestAnimationFrame()
  • optimize textureLoad in init

@munrocket munrocket changed the title one device, one context perf: one device, no async Jun 10, 2025
@munrocket munrocket mentioned this pull request Jun 11, 2025
Copy link
Contributor

@davidar davidar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's quite a lot of changes here that have been combined together which makes it difficult to review. In future please please at least try to separate them out into different commits. Merge conflicts need to be resolved.

@munrocket munrocket marked this pull request as draft June 17, 2025 07:18
@munrocket munrocket marked this pull request as ready for review July 8, 2025 14:22
@munrocket munrocket force-pushed the perf-device branch 2 times, most recently from ebb125f to b77546f Compare July 8, 2025 15:49
@munrocket
Copy link
Collaborator Author

Looks ok.

@davidar
Copy link
Contributor

davidar commented Jul 12, 2025

remove images from /app, they should be in /public

No, I moved them there so that nextjs automatically generates the metadata for them: https://nextjs.org/docs/app/api-reference/file-conventions/metadata/app-icons

If anything we could probably clean a lot of stuff out of public that isn't being used anymore.

@munrocket munrocket changed the title perf: one device, no async validation: one device, no async Jul 12, 2025
@munrocket
Copy link
Collaborator Author

Updated as you said. I just tried to remove it because it waste some time to compile metadata in dev.

@davidar
Copy link
Contributor

davidar commented Jul 19, 2025

So this is just broken for me. I open a shader, press the back button, open another shader and it's just black until I reload the page. Something is going wrong with it trying to reuse the context.

image

@davidar davidar marked this pull request as draft August 10, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants