Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Conan 1 lockfile options package_id #16509

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jun 20, 2024

Changelog: Bugfix: Fix corruption of package_id computation with dependencies options when using lockfiles
Docs: Omit
Closes: #16534

@memsharded memsharded added this to the 1.65.0 milestone Jun 20, 2024
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is this only a Conan 1.x fix? Do we need to add a test? Any open issues related?

@jasal82
Copy link
Contributor

jasal82 commented Jun 24, 2024

I reported the issue directly to Diego. If you want I can write an issue with symptoms and investigation so that it is documented.

@jasal82
Copy link
Contributor

jasal82 commented Jun 24, 2024

Related bug report is here #16534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants