Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Conan 1 lockfile options package_id #16509

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion conans/model/options.py
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,8 @@ def __eq__(self, other):
return False
# It is possible that the entry in the dict is not defined
for key, pkg_values in self._reqs_options.items():
other_values = other[key]
# We do a get so we don't artificially inject new keys in "other"
other_values = other._reqs_options.get(key, PackageOptionValues())
if not pkg_values == other_values:
return False
return True
Expand Down