-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add micromamba as a possible install tool and make it default on macOS and Windows #2075
Conversation
pre-commit.ci autofix |
@conda-forge/core @jaimergp This one appears ready for review! Shall we merge? |
Awesome stuff, really looking forward to shave off these minutes from Windows! :) |
We might need to change the |
Sounds good. We'll wait then. |
This is getting quite fast now for Windows, under a minute! conda-forge/dav1d-feedstock#21 (comment) |
Lgtm. Merge when you are ready. |
The only rough edge here is that this doesn't affect Linux at all due to the Docker images. To benefit from micromamba there we would need to:
Anyway, this is opt-in for now, so there's little risk. |
Btw, same PR but for staged-recipes: conda-forge/staged-recipes#27753 |
Why not set this as the default? |
To avoid the inconsistency between Linux and the rest, but in a way it's already inconsistent with Docker. We end up providing the same dependencies in the same base environment so I guess there's no point to be overly cautious. I'll flip the default and document this in the schema. Then folks can chime in if they have any thoughts. |
@@ -40,11 +66,9 @@ export CONDA_SOLVER="{{ conda_solver }}" | |||
export CONDA_LIBMAMBA_SOLVER_NO_CHANNELS_FROM_INSTALLED=1 | |||
{%- endif %} | |||
|
|||
{% if conda_install_tool in ("conda", "mamba") -%} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic should be flipped if conda_install_tool != 'micromamba'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm anticipating that the next install tool is a self-contained environment provider like pixi
and not another conda-like client that is first provided by a Miniforge-like installation, that's why I went with "special casing" these two.
We can just put micromamba into the existing images. Won't make a difference |
Checklist
news
entrypython conda_smithy/schema.py
)Investigating performance improvements triggered by conversation at conda-forge/conda-forge.github.io#2323.
We can use
micromamba
to save some minutes, specially in Windows. To avoid installing Miniforge if possible, I scripted that too instead of hardcoding the logic in the CI workflow template. This opens the possibility of enablingbuild-locally.py
on Windows, similar to macOS' approach.Live tests available at conda-forge/dav1d-feedstock#21