-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use D: for Windows installations on Azure #2076
base: main
Are you sure you want to change the base?
Conversation
Yes, this cuts the Miniforge installation time in half. Just installing Miniforge (not counting the mamba updates we do on top later) takes 1m10s - 1m30s (seeing times for this run of the pyside2 feedstock). Changing C: to D: means we can do it in 30s. The install times for base are: For C, 1m40s:
For D, 54s:
So, in total:
|
Can we also run builds and all on |
That's already the case :D See |
For context, we used Not sure if switching everything to |
Hm, I feared as much. Maybe this should be configurable. I doubt most feedstocks are running out of space, but for sure all of them are installing the same base environment. We can shave a few minutes of those with D: + micromamba. As long as this is documented next to the "free_disk_space" options I think we should be fine, wdyt? If that's agreeable, then I'll put some settings. |
I'm also thinking, having the cache in C: and BLD in D:... wouldn't that cause copies across drives? I don't think Windows can hardlink across drives 🤔 That would also cause slowdowns and diminish the benefits of saving space. Maybe it makes sense in some extreme cases with multi-outputs only, not sure. |
Yeah, that makes sense. The only issue here would be that feedstocks that customized CONDA_BLD_PATH to C: now has to customize MINIFORGE_HOME too. Maybe we do that in a migrator first? |
There are only 12 of them, according to the search. Could be faster to just send them manually, and I'm happy to do so :D |
Thanks. Note that those feedstocks are the heaviest loads, so keep an eye on the CI if you can. |
If only Azure respected the |
We should add short circuit skips based on the commit message to the azure templates. |
See #2077 |
I think PowerShell has a non-negligible start time, right? We can compare against the |
I don't think so. The end-to-end time of the PowerShell download was pretty fast In any event we are currently calling Python to do that download, which has its own startup time Also not sure what kind of security measures are applied on Azure. Depending on what they are, these can add overhead to startup, runtime, downloads, etc. If we are especially concerned with startup time, we could use Batch for downloading. The syntax is a little unpleasant. Though hopefully it is write once If the goal here is just generally to improve CI startup time, it might be worth revisiting Windows Docker images ( conda-forge/docker-images#209 ). With that we could do all of the download, configuration, etc. in the image. Then CI need only download the image and perhaps update before building. If Azure has a particular registry it likes, we could also push to that registry for faster downloading (and maybe opt-in to earlier scanning to avoid this cost in CI jobs) |
Yea, using |
That looks nice! I would be happy with that 😄 |
Checklist
news
entrypython conda_smithy/schema.py
)The D: drive is supposed to be faster, so let's see if that's true!