Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overrideCommand value in devcontainer so that the django container can run (#4517) #4517

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Fix overrideCommand value in devcontainer so that the django container can run (#4517) #4517

merged 1 commit into from
Aug 14, 2023

Conversation

Tharushan
Copy link
Contributor

@Tharushan Tharushan commented Aug 13, 2023

Description

A simple bugfix on devcontainer that prevented the django container from running when using VSCode with use_docker=y

How to reproduce the bug:

  • Just generate a new project using : cookiecutter gh:cookiecutter/cookiecutter-django with use_docker=y
  • Open the generated project with VSCode then you will see this popup: "Do you want to install the recommended 'Dev Containers' extension from Microsoft for this repository?" then to open it :
    image
  • After the devcontainer is built and started you will see that services are up but can't access them with http://localhost:8000 or https://localhost:8000

DevContainer documentation on this : https://containers.dev/implementors/json_reference/

image

Which states that this property should be set to

false when referencing a Docker Compose file

which is set here :

    "dockerComposeFile": [
        "../local.yml"
    ],

Checklist:

  • I've made sure that tests are updated accordingly (especially if adding or updating a template option)
  • I've updated the documentation or confirm that my change doesn't require any updates

Rationale

No open issue pointing this bug, asked on the Discord Channel if this property was set to true for a particular reason

@browniebroke browniebroke merged commit 3415586 into cookiecutter:master Aug 14, 2023
11 checks passed
@browniebroke browniebroke changed the title fix(devcontainer): overrideCommand set to false so django container can run Fix overrideCommand value in devcontainer so that the django container can run (#4517) Aug 14, 2023
@Tharushan Tharushan deleted the fix-devcontainer-default-command branch August 14, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants