fix(ui): remove inset border framing the integrated terminal - #1025
Merged
Merged
Conversation
Drop redundant top border and padding on the terminal viewer so xterm sits flush with the pane resizer instead of reading as a boxed-in inset. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_86e40e52-e621-4e5a-8b99-8773edc7f8bd) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
.terminals-viewer-hostthat stacked with the tree resizer and read as an L-shaped inset frame around the terminal column..terminal-containerso the xterm surface sits flush with the viewer instead of showing a gutter around the dark terminal background.terminal-display.e2e.tsto guard against regressions.Test plan
npx prettier --checkon changed filesnpm run build && npm run test:e2e -- --spec tests/e2e/terminal-display.e2e.ts(updatesterminal-shell-prompt.png/terminal-echo-hello.pngif layout changed)Made with Cursor