Skip to content

fix(ui): remove inset border framing the integrated terminal - #1025

Merged
jonathanKingston merged 1 commit into
mainfrom
fix/terminal-inset-border
Jul 19, 2026
Merged

jonathanKingston merged 1 commit into
mainfrom
fix/terminal-inset-border

Conversation

@jonathanKingston

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the top border on .terminals-viewer-host that stacked with the tree resizer and read as an L-shaped inset frame around the terminal column.
  • Remove padding on .terminal-container so the xterm surface sits flush with the viewer instead of showing a gutter around the dark terminal background.
  • Add a computed-style assertion in terminal-display.e2e.ts to guard against regressions.

Test plan

  • npx prettier --check on changed files
  • npm run build && npm run test:e2e -- --spec tests/e2e/terminal-display.e2e.ts (updates terminal-shell-prompt.png / terminal-echo-hello.png if layout changed)
  • Visually confirm Terminal tab: no inset box around xterm; sidebar resizer remains the only vertical seam

Made with Cursor

Drop redundant top border and padding on the terminal viewer so xterm sits flush with the pane resizer instead of reading as a boxed-in inset.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor

cursor Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_86e40e52-e621-4e5a-8b99-8773edc7f8bd)

@cursor
cursor Bot requested a review from AutomatedTester July 19, 2026 10:55

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not approving: Cursor Bugbot skipped (usage limit reached) and did not complete automated review. Requested AutomatedTester for manual review of this terminal layout CSS fix.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@jonathanKingston
jonathanKingston merged commit 09276dd into main Jul 19, 2026
20 checks passed
@jonathanKingston
jonathanKingston deleted the fix/terminal-inset-border branch July 19, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant