Skip to content

fix(ui): remove inset border framing the integrated terminal #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanKingston merged 1 commit into from
Jul 19, 2026
+20 −2
Merged

fix(ui): remove inset border framing the integrated terminal #1025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/renderer/styles/global/layout.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,8 @@
flex-direction: column;
overflow: hidden;
min-width: 0;
border-top: 1px solid var(--border-subtle);
/* The tree resizer is the seam; a top border here framed the xterm in an L
with the sidebar divider and read as an inset box around the terminal. */
}
.git-changes-host {
flex: 1;
Expand Down Expand Up @@ -967,7 +968,6 @@
}
.terminal-container {
flex: 1;
padding: var(--spacing-xs);
overflow: hidden;
-webkit-app-region: no-drag;
}
Expand Down
18 changes: 18 additions & 0 deletions tests/e2e/terminal-display.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,24 @@ describe('integrated terminal', () => {

await $('.terminal-container .xterm').waitForExist({ timeout: 30_000 })

const chrome = await browser.execute(() => {
const viewer = document.querySelector('.terminals-viewer-host')
const container = document.querySelector('.terminal-container')
if (!viewer || !container) return null
const viewerStyle = getComputedStyle(viewer)
const containerStyle = getComputedStyle(container)
return {
viewerBorderTopWidth: viewerStyle.borderTopWidth,
containerPaddingTop: containerStyle.paddingTop,
containerPaddingLeft: containerStyle.paddingLeft,
}
})
expect(chrome).toEqual({
viewerBorderTopWidth: '0px',
containerPaddingTop: '0px',
containerPaddingLeft: '0px',
})

await browser.waitUntil(
async () => {
const text = await xtermText()
Expand Down
Loading