You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Main CI CI Passed was painting red on concurrency-cancelled tip pushes after #1017 moved the gate onto self-hosted CHECKS_RUNNER.
Root cause
On tip 7fd2b097 (run 29686728400 / job 88192253327), upstream jobs were cancelled because a newer main push took the ci-refs/heads/main concurrency slot — expected supersession noise that #954/#985 already know how to treat as green.
The gate then fail-closed with:
gh: command not found
Could not resolve branch tip SHA; treating cancel as failure.
ci-runners/Dockerfile installs curl + jq but not the GitHub CLI. Hosted ubuntu-latest has gh preinstalled, so this only regressed when #1017 repointed ci-passed at ${{ vars.CHECKS_RUNNER || 'ubuntu-latest' }}.
Same pattern hit the next superseded SHA (e48ab120, run 29686756375).
Fix
In .github/workflows/ci.yml:
ci-passed tip/supersession lookups — replace gh api … --jq with curl + jq against github.api_url (Bearer github.token).
commit-screenshots head-branch probe — same swap so a missing gh cannot silently treat every branch as deleted.
Logic unchanged: tip SHA moved or newer same-SHA CI run → exit 0; genuine tip cancel → still fail closed.
Replayed failed run IDs against the REST API: cancelled 29686728400 (7fd2b097) and 29686756375 (e48ab120) both resolve a newer tip → would exit 0.
YAML parses cleanly.
Test plan
Local replay of tip/supersession API path for the two false-red runs
On next main push that cancels an in-flight tip run, CI Passed on the superseded SHA exits green with the supersession notice (no gh: command not found)
Screenshot conflicts with main were resolved automatically, but the merge updates these workflow files, which CI's token isn't scoped to push. Merge or rebase main by hand — or grant the SCREENSHOTS_PAT the workflow scope to let CI resolve these automatically:
.github/workflows/reconcile-screenshots.yml
Held — conflicts with committed work (2)
CI re-rendered these, but their committed baselines are deliberate, so the fresh render was not committed — the branch's version stands. To regenerate and take CI's render instead, add the update-screenshots label:
shot
main
this branch
todo-inline-panel.png changed on main CI render: 17360 px (1.8083%) vs committed
todo-no-plan.png changed on main CI render: 4430 px (0.4857%) vs committed
Refreshed (64)
Clearly-different shots re-rendered by the CI e2e run and committed:
63 shots re-rendered below the variance threshold (font hinting / anti-alias wobble) and were not committed. To accept them anyway, add the update-screenshots label or commit the rendered PNGs by hand.
Held — render flapping (4)
These shots alternate between two runner render states and were not committed, to stop the CI screenshot ping-pong (#609): each re-render matched a recently committed version, so committing again would just re-trigger CI and bring the other state back. If a real change is hiding here, add the update-screenshots label to force it, or pin the runner font/GPU rendering:
After #1017 moved ci-passed onto self-hosted CHECKS_RUNNER, concurrency
cancels fail-closed with `gh: command not found` — the runner image ships
curl+jq but not the GitHub CLI. Use the REST API for tip/supersession
checks (and the commit-screenshots branch probe) so cancelled superseded
runs stay green.
Co-authored-by: Jonathan Kingston <jonathanKingston@users.noreply.github.com>
The reason will be displayed to describe this comment to others. Learn more.
PR health — auto-merge kept; fleet backlog
This tip-lookup fix (curl+jq, no gh) is still the right unblocker for false-red CI Passed on cancelled superseding runs (#1006/#1044 class).
Auto-merge already on. Tip CI has been queued ~40m+ in a broader self-hosted backlog (multiple PRs queued 2–4h) — not retriggering. Once this lands, re-evaluate draft #1006.
Sent by Cursor Automation: Check in with agent-pane prs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Summary
Main CI
CI Passedwas painting red on concurrency-cancelled tip pushes after #1017 moved the gate onto self-hostedCHECKS_RUNNER.Root cause
On tip
7fd2b097(run 29686728400 / job 88192253327), upstream jobs were cancelled because a newer main push took theci-refs/heads/mainconcurrency slot — expected supersession noise that #954/#985 already know how to treat as green.The gate then fail-closed with:
ci-runners/Dockerfileinstallscurl+jqbut not the GitHub CLI. Hostedubuntu-latesthasghpreinstalled, so this only regressed when #1017 repointedci-passedat${{ vars.CHECKS_RUNNER || 'ubuntu-latest' }}.Same pattern hit the next superseded SHA (
e48ab120, run 29686756375).Fix
In
.github/workflows/ci.yml:ci-passedtip/supersession lookups — replacegh api … --jqwithcurl+jqagainstgithub.api_url(Bearergithub.token).commit-screenshotshead-branch probe — same swap so a missingghcannot silently treat every branch as deleted.Logic unchanged: tip SHA moved or newer same-SHA CI run → exit 0; genuine tip cancel → still fail closed.
Validation
gh: command not found/ curl tip lookup). Related but different: fix(ci): reconcile-screenshots no-ops when PR merges mid-run #1008 (reconcile mid-merge), fix(ci): restore split-tier burst slots + real deleteSession swallow #1006 (burst runners). fix(ci): treat same-SHA concurrency cancels as CI Passed #985/fix(deps): override adm-zip to 0.6.0 for npm audit gate #1012 already merged.29686728400(7fd2b097) and29686756375(e48ab120) both resolve a newer tip → would exit 0.Test plan
CI Passedon the superseded SHA exits green with the supersession notice (nogh: command not found)