NOTICK: Remove ExtendedStackTraceHotSpot #85
Draft
+8
−352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephzunigadaly
force-pushed
the
jzd/NOTICK-Remove-ExtendedStackTraceHotSpot
branch
from
d04a921 to
46608a7
Compare
ExtendedStackTraceHotSpot is an alternative to ExtendedStackTrace/ExtendedStackTraceClassContext that only works on the Oracle JVM. This code path may have improved performance in the Oracle JVM. I would expect that removing this will make both JVMs perform equally. We already find the performance of OpenJDK acceptable so this should be an acceptable decrease for OracleJDK. Removing this gives us the same code paths on both JVMs. That means that testing on OpenJDK will be enough without setting up another environment to test the Oracle JDK paths. It also reduces the code we need to maintain.
josephzunigadaly
force-pushed
the
jzd/NOTICK-Remove-ExtendedStackTraceHotSpot
branch
from
46608a7 to
2250f87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtendedStackTraceHotSpotis an alternative toExtendedStackTrace/ExtendedStackTraceClassContextthat only works on the Oracle JVM.A code path that is only activated on a single JVM is a risk. It leaves open the opportunity for behaviour differences, requires multiple test environments to fully test and takes developer time to maintain both code paths.