Clean the predicate attribute or operands in neura operations#137
Merged
tancheng merged 12 commits intocoredac:mainfrom Oct 6, 2025
Merged
Clean the predicate attribute or operands in neura operations#137tancheng merged 12 commits intocoredac:mainfrom
tancheng merged 12 commits intocoredac:mainfrom
Conversation
…asm and yaml output
tancheng
reviewed
Sep 30, 2025
Contributor
|
Thanks @MeowMJ for the cleanup. That's a lot! |
Contributor
|
Hi @MeowMJ, can we try to merge this PR ASAP~? Thanks! |
tancheng
reviewed
Oct 5, 2025
tancheng
reviewed
Oct 5, 2025
tancheng
approved these changes
Oct 5, 2025
ShangkunLi
pushed a commit
that referenced
this pull request
Mar 12, 2026
Clean the predicate attribute or operands in neura operations
ShangkunLi
pushed a commit
that referenced
this pull request
Mar 12, 2026
Clean the predicate attribute or operands in neura operations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this Pull Request, we remove all the optional predicate attributes in
NeuraOps.td, with*_embed_predicatetest provided for validity. This PR belongs to Issue #116 .