Skip to content

Clean the predicate attribute or operands in neura operations #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tancheng merged 12 commits into from
Oct 6, 2025
Merged

Clean the predicate attribute or operands in neura operations #137

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c73754b
[UPDATE] NeuraOp.td, remove predicate
MeowMJ Sep 16, 2025
8111fb6
[UPDATE] basic_operation test, delete old predicate, add embed_predicate
MeowMJ Sep 16, 2025
a7f172a
[UPDATE] neura-interpreter remove predicate
MeowMJ Sep 17, 2025
f0f0d2b
[New Merge] merge with new commits
MeowMJ Sep 29, 2025
dfdea60
[UPDATE] remove all predicate in mlir-neura-opt output and check the …
MeowMJ Sep 30, 2025
e3b856f
[DELETE] all outputs
MeowMJ Oct 5, 2025
27fd0f7
[DELETE] all embed predicate test
MeowMJ Oct 5, 2025
9a7d448
[RESLOVE] conflict
MeowMJ Oct 5, 2025
5204724
[DELETE] accident repetition
MeowMJ Oct 5, 2025
cbb2e23
[DELETE] all false predicate func
MeowMJ Oct 5, 2025
cb91999
[UPDATE] cast.mlir with predicate
MeowMJ Oct 5, 2025
70935dc
[UPDATE] cast.mlir with one embed predicate
MeowMJ Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,10 @@ Build LLVM & Neura
- Test:
```sh
$ cd ../test
# a test with detailed middle output
$ ../build/tools/mlir-neura-opt/mlir-neura-opt --debug test.mlir

# Or test with lit:
$ /workspace/llvm-project/build/bin/llvm-lit . -v
$ /workspace/llvm-project/build/bin/llvm-lit test.mlir -v
```

98 changes: 47 additions & 51 deletions include/NeuraDialect/NeuraOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,7 @@ include "NeuraDialect/NeuraDialect.td"
// Defines basic scalar operations.

def Neura_ConstantOp : Op<NeuraDialect, "constant"> {
let arguments = (ins
AnyAttr:$value,
OptionalAttr<BoolAttr>:$predicate // Add optional predicate attribute
);
let arguments = (ins AnyAttr:$value);
let results = (outs AnyType:$result);
// let assemblyFormat = "attr-dict `:` type($result)";
}
Expand All @@ -20,15 +17,15 @@ def Neura_AddOp : Op<NeuraDialect, "add"> {
let opName = "add";
let arguments = (ins AnyType:$lhs, Optional<AnyType>:$rhs);
let results = (outs AnyType:$result);
// let assemblyFormat = "$lhs `,` $rhs `,` $predicate attr-dict `:` type($result)";
// let assemblyFormat = "$lhs `,` $rhs `,` attr-dict `:` type($result)";
let traits = [SameOperandsAndResultElementType];
}

def Neura_SubOp : Op<NeuraDialect, "sub"> {
let summary = "Integer substraction operation";
let arguments = (ins AnyType:$lhs, Optional<AnyType>:$rhs);
let results = (outs AnyType:$result);
// let assemblyFormat = "$lhs `,` $rhs `,` $predicate attr-dict `:` type($result)";
// let assemblyFormat = "$lhs `,` $rhs `,` attr-dict `:` type($result)";
let traits = [SameOperandsAndResultElementType];
}

Expand All @@ -37,15 +34,15 @@ def Neura_MulOp : Op<NeuraDialect, "mul"> {
let opName = "mul";
let arguments = (ins AnyType:$lhs, Optional<AnyType>:$rhs);
let results = (outs AnyType:$result);
// let assemblyFormat = "$lhs `,` $rhs `,` $predicate attr-dict `:` type($result)";
// let assemblyFormat = "$lhs `,` $rhs `,` attr-dict `:` type($result)";
let traits = [SameOperandsAndResultElementType];
}

def Neura_DivOp : Op<NeuraDialect, "div"> {
let summary = "Integer division operation";
let arguments = (ins AnyType:$lhs, Optional<AnyType>:$rhs);
let results = (outs AnyType:$result);
// let assemblyFormat = "$lhs `,` $rhs `,` $predicate attr-dict `:` type($result)";
// let assemblyFormat = "$lhs `,` $rhs `,` attr-dict `:` type($result)";
let traits = [SameOperandsAndResultElementType];
}

Expand All @@ -54,7 +51,7 @@ def Neura_RemOp : Op<NeuraDialect, "rem">{
let description = [{
Performs an integer remainder operation, computing the result of
a % b, where % is the remainder operator.

Example:
%result = neura.rem %a, %b : i32
}];
Expand Down Expand Up @@ -87,9 +84,9 @@ def Neura_FSubOp: Op<NeuraDialect, "fsub"> {
def Neura_FMulOp : Op<NeuraDialect, "fmul"> {
let summary = "Floating multiplication operation";
let opName = "fmul";
let arguments = (ins AnyType:$lhs, AnyType:$rhs, Optional<AnyType>:$predicate);
let arguments = (ins AnyType:$lhs, AnyType:$rhs);
let results = (outs AnyType:$result);
// let assemblyFormat = "$lhs `,` $rhs `,` $predicate attr-dict `:` type($result)";
// let assemblyFormat = "$lhs `,` $rhs `,` attr-dict `:` type($result)";
// let traits = [SameOperandsAndResultElementType];
}

Expand All @@ -103,9 +100,9 @@ def Neura_FDivOp : Op<NeuraDialect, "fdiv"> {
// Defines a bitwise OR operation.
def Neura_OrOp : Op<NeuraDialect, "or"> {
let summary = "Bitwise OR operation";
let arguments = (ins AnySignlessInteger:$lhs, AnySignlessInteger:$rhs, Optional<AnyType>:$predicate);
let arguments = (ins AnySignlessInteger:$lhs, AnySignlessInteger:$rhs);
let results = (outs AnySignlessInteger:$result);
// let assemblyFormat = "$lhs `,` $rhs `,` $predicate attr-dict `:` type($result)";
// let assemblyFormat = "$lhs `,` $rhs `,` attr-dict `:` type($result)";
let traits = [SameOperandsAndResultElementType];
}

Expand Down Expand Up @@ -134,44 +131,44 @@ def Neura_FCmpOp : Op<NeuraDialect, "fcmp"> {

// Defines a load operation.
def Neura_LoadOp : Op<NeuraDialect, "load"> {
let arguments = (ins AnyType:$addr, Optional<AnyType>:$predicate);
let arguments = (ins AnyType:$addr);
let results = (outs AnyType:$value);
// let assemblyFormat = "$addr `,` $predicate attr-dict `:` type($value)";
// let assemblyFormat = "$addr `,` attr-dict `:` type($value)";
}

// Defines a store operation.
def Neura_StoreOp : Op<NeuraDialect, "store"> {
let arguments = (ins AnyType:$value, AnyType:$addr, Optional<AnyType>:$predicate);
let arguments = (ins AnyType:$value, AnyType:$addr);
let results = (outs);
// let assemblyFormat = "$value `,` $addr `,` $predicate attr-dict";
// let assemblyFormat = "$value `,` $addr `,` attr-dict";
}

// Defines a load operation with integrated address calculation.
def Neura_LoadIndexedOp: Op<NeuraDialect, "load_indexed", [AttrSizedOperandSegments]>{
def Neura_LoadIndexedOp: Op<NeuraDialect, "load_indexed">{
let summary = "Load with integrated address calculation for multi-dimensional arrays";
let description = [{
Calculates the address using the base address and indices.
Load the value at the calculated address.
Example:
%value = neura.load_indexed %base [%arg1, %arg2] : f32
}];
let arguments = (ins AnyType:$base, Variadic<AnyType>:$indices, Optional<AnyType>:$predicate);
let arguments = (ins AnyType:$base, Variadic<AnyType>:$indices);
let results = (outs AnyType:$result);
let assemblyFormat = "$base `[` $indices `:` type($indices) `]` type($base) ($predicate^ `:` type($predicate))? attr-dict `:` type($result)";
let assemblyFormat = "$base `[` $indices `:` type($indices) `]` type($base) attr-dict `:` type($result)";
}

//Defines a store operation with integrated address calculation.
def Neura_StoreIndexedOp: Op<NeuraDialect, "store_indexed", [AttrSizedOperandSegments]> {
def Neura_StoreIndexedOp: Op<NeuraDialect, "store_indexed"> {
let summary = "Store with integrated address calculation for multi-dimensional arrays";
let description = [{
Calculates the address using the base address and indices.
Store the value at the calculated address.
Example:
neura.store_indexed %value, %base [%arg1, %arg2] : f32
}];
let arguments = (ins AnyType:$value, AnyType:$base, Variadic<AnyType>:$indices, Optional<AnyType>:$predicate);
let arguments = (ins AnyType:$value, AnyType:$base, Variadic<AnyType>:$indices);
let results = (outs);
let assemblyFormat = "$value `to` $base `[` $indices `:` type($indices) `]` type($base) ($predicate^ `:` type($predicate))? attr-dict `:` type($value)";
let assemblyFormat = "$value `to` $base `[` $indices `:` type($indices) `]` type($base) attr-dict `:` type($value)";
}

// Defines a pointer computation operation.
Expand All @@ -185,11 +182,10 @@ def Neura_GEP : Op<NeuraDialect, "gep"> {
// Defines a conditional branch operation.
def Neura_CondBr : Op<NeuraDialect, "cond_br", [Terminator, AttrSizedOperandSegments]> {
let arguments = (ins AnyType:$condition,
Optional<AnyType>:$predicate,
Variadic<AnyType>:$trueArgs,
Variadic<AnyType>:$falseArgs);
let successors = (successor AnySuccessor:$trueDest, AnySuccessor:$falseDest);
let assemblyFormat = "$condition `:` type($condition) ($predicate^ `:` type($predicate))? `then` ($trueArgs^ `:` type($trueArgs))? `to` $trueDest `else` ($falseArgs^ `:` type($falseArgs))? `to` $falseDest attr-dict";
let assemblyFormat = "$condition `:` type($condition) `then` ($trueArgs^ `:` type($trueArgs))? `to` $trueDest `else` ($falseArgs^ `:` type($falseArgs))? `to` $falseDest attr-dict";
}

// Defines an unconditional branch operation.
Expand All @@ -214,15 +210,15 @@ def Neura_NotOp : Op<NeuraDialect, "not"> {
// Defines a return operation.
def Neura_ReturnOp : Op<NeuraDialect, "return", [Terminator]> {
let arguments = (ins Variadic<AnyType>:$values);
// let assemblyFormat = "($values^)? `,` $predicate attr-dict";
// let assemblyFormat = "($values^)? `,` attr-dict";
}

// Defines a cast operation for type conversion.
def Neura_CastOp : Op<NeuraDialect, "cast">{
let summary = "Generic type conversion operation";
let arguments = (ins AnyType:$input, StrAttr:$cast_type, Optional<AnyType>:$predicate);
let arguments = (ins AnyType:$input, StrAttr:$cast_type);
let results = (outs AnyType:$result);
// let assemblyFormat = "$input type($input) `->` type($output) `,` $predicate attr-dict";
// let assemblyFormat = "$input type($input) `->` type($output) `,` attr-dict";
}

// Defines an alloca operation for memory allocation.
Expand All @@ -231,11 +227,11 @@ def Neura_AllocaOp : Op<NeuraDialect, "alloca"> {
let description = [{
Allocates memory on the stack, similar to llvm.alloca.
Takes a predicated size value and returns a pointer to the allocated memory.

Example:
%ptr = neura.alloca %size : !neura.data<i32, i1> -> !llvm.ptr
}];

let arguments = (ins Optional<AnyType>:$size);
let results = (outs AnyType:$result);
let assemblyFormat = "($size^ `:` type($size))? attr-dict `->` type($result)";
Expand All @@ -247,11 +243,11 @@ def Neura_SExtOp : Op<NeuraDialect, "sext"> {
let description = [{
Sign extends a value from a smaller integer type to a larger integer type.
Similar to llvm.sext, but works with predicated values.

Example:
%extended = neura.sext %value : !neura.data<i8, i1> -> !neura.data<i32, i1>
}];

let arguments = (ins AnyType:$value);
let results = (outs AnyType:$result);
let assemblyFormat = "$value attr-dict `:` type($value) `->` type($result)";
Expand All @@ -263,11 +259,11 @@ def Neura_ZExtOp : Op<NeuraDialect, "zext"> {
let description = [{
Zero extends a value from a smaller integer type to a larger integer type.
Similar to llvm.zext, but works with predicated values.

Example:
%extended = neura.zext %value : !neura.data<i8, i1> -> !neura.data<i32, i1>
}];

let arguments = (ins AnyType:$value);
let results = (outs AnyType:$result);
let assemblyFormat = "$value attr-dict `:` type($value) `->` type($result)";
Expand All @@ -286,7 +282,7 @@ def Neura_ShlOp : Op<NeuraDialect, "shl"> {
let arguments = (ins AnyType:$value, Optional<AnyType>:$shiftAmount);
let results = (outs AnyType:$result);
}

// ----------------------------------------------------
// Defines vector operations.

Expand All @@ -303,9 +299,9 @@ def VectorOfAnyFloat :
def Neura_VFMulOp : Op<NeuraDialect, "vfmul"> {
let summary = "Vector floating multiplication operation";
let opName = "vfmul";
let arguments = (ins VectorOfAnyFloat:$lhs, VectorOfAnyFloat:$rhs, Optional<AnyType>:$predicate);
let arguments = (ins VectorOfAnyFloat:$lhs, VectorOfAnyFloat:$rhs);
let results = (outs VectorOfAnyFloat:$result);
// let assemblyFormat = "$lhs `,` $rhs `,` $predicate attr-dict `:` type($result)";
// let assemblyFormat = "$lhs `,` $rhs `,` attr-dict `:` type($result)";
let traits = [SameOperandsAndResultElementType];
}

Expand All @@ -314,17 +310,17 @@ def Neura_VFMulOp : Op<NeuraDialect, "vfmul"> {

def Neura_FAddFAddOp : Op<NeuraDialect, "fadd_fadd"> {
let summary = "Fused fadd(fadd(a, b), c)";
let arguments = (ins AnyType:$a, AnyType:$b, AnyType:$c, Optional<AnyType>:$predicate);
let arguments = (ins AnyType:$a, AnyType:$b, AnyType:$c);
let results = (outs AnyType:$result);
// let assemblyFormat = "$a `,` $b `,` $c `,` $predicate attr-dict `:` type($result)";
// let assemblyFormat = "$a `,` $b `,` $c `,` attr-dict `:` type($result)";
let traits = [SameOperandsAndResultElementType];
}

def Neura_FMulFAddOp : Op<NeuraDialect, "fmul_fadd"> {
let summary = "Fused fadd(fmul(a, b), c)";
let arguments = (ins AnyType:$a, AnyType:$b, AnyType:$c, Optional<AnyType>:$predicate);
let arguments = (ins AnyType:$a, AnyType:$b, AnyType:$c);
let results = (outs AnyType:$result);
// let assemblyFormat = "$a `,` $b `,` $c `,` $predicate attr-dict `:` type($result)";
// let assemblyFormat = "$a `,` $b `,` $c `,` attr-dict `:` type($result)";
let traits = [SameOperandsAndResultElementType];
}

Expand All @@ -346,7 +342,7 @@ def Neura_PhiOp : Op<NeuraDialect, "phi"> {
let description = [{
Merges values from different control paths in dataflow form.
Used with reserve and ctrl_mov to represent control flow.

Example:
%v = neura.reserve : f32 // Create placeholder
%result = neura.phi %init, %v // Merge initial and loop-carried values
Expand Down Expand Up @@ -385,7 +381,7 @@ def Neura_ReserveOp : Op<NeuraDialect, "reserve"> {
let description = [{
Creates a placeholder value that will be connected via ctrl_mov.
Used to represent control flow dependencies in dataflow form.

Example:
%v = neura.reserve : f32 // Create placeholder
%result = neura.phi %init, %v // Use in phi node
Expand All @@ -402,7 +398,7 @@ def Neura_GrantPredicateOp : Op<NeuraDialect, "grant_predicate"> {
let description = [{
Takes a predicated value and a predicate (i1), producing a new predicated
value whose predicate bit is set to the given condition.

Example:
%g = neura.grant_predicate %val, %pred : !neura.data<f32, i1>, !neura.data<i1, i1> -> !neura.data<f32, i1>
}];
Expand All @@ -418,13 +414,13 @@ def Neura_GrantOnceOp : Op<NeuraDialect, "grant_once"> {
let description = [{
Either grants a value a one-time predicate, or creates a constant value with a one-time predicate. The resulting value is considered valid
only during its first activation. Used to initialize recurrence cycles.

Example:
%v = neura.grant_once %init : !neura.data<f32, i1> -> !neura.data<f32, i1>
%c = neura.grant_once <{value = 42 : i64}> : !neura.data<i64, i1>
}];

let arguments = (ins
let arguments = (ins
Optional<AnyType>:$value,
OptionalAttr<AnyAttr>:$constant_value);
let results = (outs AnyType:$result);
Expand All @@ -437,12 +433,12 @@ def Neura_GrantAlwaysOp : Op<NeuraDialect, "grant_always"> {
let description = [{
Grants a value always-valid predicate: the resulting value is considered valid
during the entire application lifetime.

Example:
%v = neura.grant_always %init : !neura.data<f32, i1> -> !neura.data<f32, i1>
}];

let arguments = (ins
let arguments = (ins
Optional<AnyType>:$value,
OptionalAttr<AnyAttr>:$constant_value);
let results = (outs AnyType:$result);
Expand All @@ -458,13 +454,13 @@ def Neura_LoopControlOp : Op<NeuraDialect, "loop_control">{
let description = [{
Controls loop execution with minimal recurrence cycle length (1).
Takes the current index and produces the next index and validity predicate.

This operation combines comparison and increment logic into a single operation,
enabling efficient loop execution on dataflow architectures with modulo scheduling.

The first iteration automatically uses the start value because the reserve operation's
predicate bit is initially 0, while the start value's predicate bit is 1.

Example:
// Shows loop control that calculates next index and validity in one step.
%next_idx, %loop_valid = neura.loop_control(
Expand Down
Loading
Loading