Refactor test RUN commands into a separate tool
#355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmccutchen-cci
referenced
this pull request
Dec 14, 2020
mattmccutchen-cci
force-pushed
the
test-command-refactoring
branch
from
17b42ff
to
3225c31
Compare
mattmccutchen-cci
force-pushed
the
test-command-refactoring.base
branch
from
9a8a7b2
to
d6670af
Compare
mattmccutchen-cci
force-pushed
the
test-command-refactoring
branch
from
f2f1e08
to
370a623
Compare
Fixes: - Comment about #_MARKER_# - abspath
converted to 3c-regtest. `llvm-lit b9_allsafestructp.c` passes, and `./3c-regtest-unconvert.py b9_allsafestructp.c` prints its content as of the test-command-refactoring.base branch.
3c-regtest. Made needed enhancements to the 3c-regtest tools: - Add support for the rest of the RUN scripts. - Add support for RUN scripts with blank lines in the middle, as used by the common-testgenerator script. A few tests are failing verification, i.e., their existing RUN scripts didn't match the ones generated by the test updating programs. To investigate.
mattmccutchen-cci
force-pushed
the
test-command-refactoring
branch
from
370a623
to
6691373
Compare
This was referenced Jan 14, 2021
13 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress. Part of #346.
I'm currently using a PR target branch
test-command-refactoring.basethat I set up specifically as a merge of the changes that this PR depends on but that are not part of the PR, so we can see the proper PR diff. After the dependencies are merged, I'll change the PR target branch to the default branch.Current status: All tests managed by the test updating programs are converted to
3c-regtest, but a few are failing verification, i.e., their existing RUN scripts didn't match the ones generated by the test updating programs.