Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test RUN commands into a separate tool #355

Draft
wants to merge 5 commits into
base: test-command-refactoring.base
Choose a base branch
from
Draft

Refactor test RUN commands into a separate tool #355

wants to merge 5 commits into from

Commits on Jan 13, 2021

  1. Add 3c-regtest.py and migrate one example test to use it. 

    Fixes:
- Comment about #_MARKER_#
- abspath
    @mattmccutchen-cci
    mattmccutchen-cci committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    2ecd734 View commit details
    Browse the repository at this point in the history

  2. Redesign to support verification that a test file has been correctly 

    converted to 3c-regtest.

`llvm-lit b9_allsafestructp.c` passes, and
`./3c-regtest-unconvert.py b9_allsafestructp.c` prints its content as of
the test-command-refactoring.base branch.
    @mattmccutchen-cci
    mattmccutchen-cci committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    15d87eb View commit details
    Browse the repository at this point in the history

  3. Remove the tests that were deleted in #364 from test_updater.py.

    @mattmccutchen-cci
    mattmccutchen-cci committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    17f60c0 View commit details
    Browse the repository at this point in the history

  4. Convert the rest of the tests managed by the "test updating programs" to 

    3c-regtest.

Made needed enhancements to the 3c-regtest tools:

- Add support for the rest of the RUN scripts.

- Add support for RUN scripts with blank lines in the middle, as used by
  the common-testgenerator script.

A few tests are failing verification, i.e., their existing RUN scripts
didn't match the ones generated by the test updating programs.  To
investigate.
    @mattmccutchen-cci
    mattmccutchen-cci committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    b1745b6 View commit details
    Browse the repository at this point in the history

  5. A few test_updater tests no longer need a "diff -w".

    @mattmccutchen-cci
    mattmccutchen-cci committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    6691373 View commit details
    Browse the repository at this point in the history