Fix blinking thumbnail row #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a thumbnail URL is invalid, it triggers the onThumbnailError handler and we display a default thumbnail in CSS. If the HTML view is reloaded (which happens a lot), it triggers again and again the onThumbnailError and the default thumbnail in CSS handler leading to a blinking thumbnail. Now we change directly the thumbnail URL with the default one. So no onThumbnailError handler triggered. When the sync will be done, a new cipher row will a new thumbnail URL.
Ldoppea
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a thumbnail URL is invalid, it triggers the onThumbnailError handler and we display a default thumbnail in CSS. If the HTML view is reloaded (which happens a lot), it triggers again and again the onThumbnailError and the default thumbnail in CSS handler leading to a blinking thumbnail.
Now we change directly the thumbnail URL with the default one. So no onThumbnailError handler triggered. When the sync will be done, a new cipher row will a new thumbnail URL.