Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blinking thumbnail row #194

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Fix blinking thumbnail row #194

merged 1 commit into from
Apr 25, 2024

Commits on Apr 25, 2024

  1. feat: Avoid thumbnail blinking in cipher row 

    When a thumbnail URL is invalid, it triggers the onThumbnailError
handler and we display a default thumbnail in CSS. If the HTML view
is reloaded (which happens a lot), it triggers again and again the
onThumbnailError and the default thumbnail in CSS handler leading to
a blinking thumbnail.

Now we change directly the thumbnail URL with the default one. So no
onThumbnailError handler triggered. When the sync will be done, a new
cipher row will a new thumbnail URL.
    @zatteo
    zatteo committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    fe5098b View commit details
    Browse the repository at this point in the history