feat: Handle contacts in inPageMenu #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldoppea
force-pushed
the
fix/inpage_menu_contacts
branch
from
1e84052
to
33c3c66
Compare
`getAllDecryptedForUrl()` is meant to return only Login ciphers except if the `includeOtherTypes` parameter is provided. If it is the case, then `getAllDecryptedForUrl()` will also return requested types With previous implementation we always returned Contacts ciphers whatever the value of `includeOtherTypes` is The side effect was that the inPageMenu would stop working as the `logins` entry is filled from `getAllDecryptedForUrl()` call is is not able to handle Contacts (ses `runtime.background.ts` in the `bgAnswerMenuRequest` message section) By fixing this, we revert the 3bf4e54 behavior, so we need to counter this by adding the Contacts type in the `includeOtherTypes` params in `current-tab.component` code Also we choose to include it if the `dontShowIdentities` option is `false` as Contacts are meant to replace identities, so there is no need to create a new option
We want Contacts ciphers to appear in the InPage menu In order to keep the menu usable, for now we limite the menu to display only `me` and favorites contacts In the future we may implement a search feature allowing to access other contacts
Auto stash before rebase of "refs/heads/fix/inpage_menu_contacts"
zatteo
force-pushed
the
fix/inpage_menu_contacts
branch
from
21ab42c
to
a982730
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want Contacts ciphers to appear in the InPage menu
In order to keep the menu usable, for now we limite the menu to display only
meand favorites contactsIn the future we may implement a search feature allowing to access other contacts