Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Handle contacts in inPageMenu #198

Merged
merged 6 commits into from
May 3, 2024
Merged

feat: Handle contacts in inPageMenu #198

merged 6 commits into from
May 3, 2024

Commits on May 3, 2024

  1. fix: Return contact from getAllDecryptedForUrl only if includeOtherTypes 

    `getAllDecryptedForUrl()` is meant to return only Login ciphers except
if the `includeOtherTypes` parameter is provided. If it is the case,
then `getAllDecryptedForUrl()` will also return requested types

With previous implementation we always returned Contacts ciphers
whatever the value of `includeOtherTypes` is

The side effect was that the inPageMenu would stop working as the
`logins` entry is filled from `getAllDecryptedForUrl()` call is is not
able to handle Contacts (ses `runtime.background.ts` in the
`bgAnswerMenuRequest` message section)

By fixing this, we revert the 3bf4e54
behavior, so we need to counter this by adding the Contacts type in the
`includeOtherTypes` params in `current-tab.component` code

Also we choose to include it if the `dontShowIdentities` option is
`false` as Contacts are meant to replace identities, so there is no
need to create a new option
    @Ldoppea @zatteo
    Ldoppea authored and zatteo committed May 3, 2024
    Configuration menu
    Copy the full SHA
    6025946 View commit details
    Browse the repository at this point in the history

  2. feat: Handle contacts in inPageMenu 

    We want Contacts ciphers to appear in the InPage menu

In order to keep the menu usable, for now we limite the menu to display
only `me` and favorites contacts

In the future we may implement a search feature allowing to access
other contacts
    @Ldoppea @zatteo
    Ldoppea authored and zatteo committed May 3, 2024
    Configuration menu
    Copy the full SHA
    499b943 View commit details
    Browse the repository at this point in the history

  3. refactor: Move DecisionArray evaluation code

    @Ldoppea @zatteo
    Ldoppea authored and zatteo committed May 3, 2024
    Configuration menu
    Copy the full SHA
    88894bb View commit details
    Browse the repository at this point in the history

  4. feat: Add Contact ciphers to the evaluateDecision process 

    Auto stash before rebase of "refs/heads/fix/inpage_menu_contacts"
    @Ldoppea @zatteo
    Ldoppea authored and zatteo committed May 3, 2024
    Configuration menu
    Copy the full SHA
    4632dd8 View commit details
    Browse the repository at this point in the history

  5. docs: Improve evaluateDecision process' documentation

    @Ldoppea @zatteo
    Ldoppea authored and zatteo committed May 3, 2024
    Configuration menu
    Copy the full SHA
    ea8879a View commit details
    Browse the repository at this point in the history

  6. fix: Prettier for DecisionArray code

    @zatteo
    zatteo committed May 3, 2024
    Configuration menu
    Copy the full SHA
    a982730 View commit details
    Browse the repository at this point in the history