Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call cryptoService.makeKey directly form computeMasterKey #162

Merged
merged 1 commit into from
Sep 9, 2021

Commits on Sep 8, 2021

  1. fix: call cryptoService.makeKey directly form computeMasterKey

    Previous version introduced unnecessary complexity as `kdfIterations`
    and `kdf` were ignored by `authService.makePreloginKey()`
    
    Also the `iterations` handling did not work correctly as the ternary
    operator was reversed
    
    As the only value of `authService.makePreloginKey()` is to query
    `kdfIterations` and `kdf` and because we never call
    `computeMasterKey()` with those values unset, then we call
    `cryptoService.makeKey()` directly
    Ldoppea committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    e54dfad View commit details
    Browse the repository at this point in the history