Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare to test branch #32

Closed
wants to merge 4 commits into from
Closed

prepare to test branch #32

wants to merge 4 commits into from

Conversation

2bndy5
Copy link
Collaborator

@2bndy5 2bndy5 commented Feb 12, 2024

test action CI

test action CI
@2bndy5 2bndy5 marked this pull request as ready for review February 12, 2024 21:48
github-actions[bot]

This comment was marked as duplicate.

@github-actions github-actions bot dismissed their stale review February 12, 2024 21:56

outdated suggestion

github-actions[bot]

This comment was marked as duplicate.

@github-actions github-actions bot dismissed their stale review February 12, 2024 22:02

outdated suggestion

github-actions[bot]

This comment was marked as outdated.

@github-actions github-actions bot dismissed their stale review February 13, 2024 18:28

outdated suggestion

github-actions[bot]

This comment was marked as outdated.

@github-actions github-actions bot dismissed their stale review February 13, 2024 18:53

outdated suggestion

github-actions[bot]

This comment was marked as outdated.

Copy link

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 2 file(s) not formatted
  • src/demo.cpp
  • src/demo.hpp
clang-tidy reports: 7 concern(s)

Have any feedback or feature suggestions? Share it here.

@github-actions github-actions bot dismissed their stale review February 13, 2024 20:15

outdated suggestion

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Click here for the full clang-tidy patch
diff --git a/src/demo.cpp b/src/demo.cpp
index fc295c3..b160609 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -3 +3 @@
-#include <stdio.h>
+#include <cstdio>
@@ -4,0 +5,2 @@
+auto main() -> int
+{
@@ -6,6 +8,3 @@
-
-
-int main(){
-
-    for (;;) break;
-
+    for (;;) {
+        break;
+    }
@@ -18 +17,2 @@ int main(){
-    return 0;}
+    return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index a429f5c..115b0de 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -6,3 +6,3 @@ class Dummy {
-    char* useless;
-    int numb;
-    Dummy() :numb(0), useless("\0"){}
+    char* useless { "\0" };
+    int numb { 0 };
+    Dummy() { }
@@ -10,2 +10,2 @@ class Dummy {
-    public:
-    void *not_useful(char *str){useless = str;}
+public:
+    auto not_useful(char* str) -> void* { useless = str; }

Have any feedback or feature suggestions? Share it here.

@@ -1,17 +1,18 @@
/** This is a very ugly test code (doomed to fail linting) */
#include "demo.hpp"
#include <cstdio>
#include <cstddef>
#include <stdio.h>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy diagnostics

Suggested change
#include <stdio.h>
#include <cstdio>


// using size_t from cstddef
size_t dummyFunc(size_t i) { return i; }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy suggestions

Suggested change
auto main() -> int
{

Comment on lines +6 to +11


int main(){

for (;;) break;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy diagnostics

Suggested change
int main(){
for (;;) break;
for (;;) {
break;
}




return 0;}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy suggestions

Suggested change
return 0;}
return 0;
}

Comment on lines 6 to +8
char* useless;
int numb;
Dummy() :numb(0), useless("\0"){}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy diagnostics

Suggested change
char* useless;
int numb;
Dummy() :numb(0), useless("\0"){}
char* useless { "\0" };
int numb { 0 };
Dummy() { }

Comment on lines 10 to +11
public:
void *not_usefull(char *str){
useless = str;
return 0;
}
void *not_useful(char *str){useless = str;}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy diagnostics

Suggested change
public:
void *not_usefull(char *str){
useless = str;
return 0;
}
void *not_useful(char *str){useless = str;}
public:
auto not_useful(char* str) -> void* { useless = str; }

int main(){

for (;;) break;


printf("Hello world!\n");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy diagnostic

src/demo.cpp:13:5: warning: [cppcoreguidelines-pro-type-vararg]

do not call c-style vararg functions

    printf("Hello world!\n");
    ^

@2bndy5 2bndy5 closed this Feb 14, 2024
@2bndy5 2bndy5 deleted the test-pr-reviews branch February 14, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant