cpp-linter · 2bndy5 · Feb 12, 2024 · Feb 13, 2024 · Feb 13, 2024 · Feb 13, 2024
diff --git a/.github/workflows/cpp-lint-action.yml b/.github/workflows/cpp-lint-action.yml
@@ -3,6 +3,7 @@ name: cpp-linter as action
 on:
   workflow_dispatch:
   workflow_call:
+  # pull_request:
 
 
 jobs:
@@ -32,27 +33,29 @@ jobs:
         run: mkdir build && cmake -Bbuild src
 
       - name: Run linter as action
-        uses: cpp-linter/cpp-linter-action@latest
+        uses: cpp-linter/cpp-linter-action@dependabot/pip/cpp-linter-1.7.0
         id: linter
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           style: file
-          files-changed-only: false
+          files-changed-only: true
+          lines-changed-only: true
           # to ignore all build folder contents
           ignore: build
           database: build
-          verbosity: 9
+          # verbosity: debug
           version: ${{ matrix.clang-version }}
-          thread-comments: ${{ matrix.clang-version == '12' }}
-          file-annotations: ${{ matrix.clang-version == '12' }}
+          thread-comments: ${{ matrix.clang-version == '16' }}
+          file-annotations: ${{ matrix.clang-version == '16' }}
           extra-args: -std=c++14 -Wall
+          tidy-review: ${{ matrix.clang-version == '16' }}
+          # format-review: ${{ matrix.clang-version == '16' }}
 
       - name: Fail fast?!
         # if: steps.linter.outputs.checks-failed > 0
         run: | 
           echo "some linter checks failed"
           echo "${{ steps.linter.outputs.checks-failed }}"
-          echo "${{ env.checks-failed }}"
         # for actual deployment
         # run: exit 1
diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml
@@ -7,16 +7,17 @@ on:
         description: 'which branch to test'
         default: 'main'
         required: true
+  pull_request:
 
 jobs:
   cpp-linter:
     runs-on: windows-latest
 
     strategy:
       matrix:
-        clang-version: ['7', '8', '9','10', '11', '12', '13', '14', '15', '16', '17']
+        clang-version: ['10', '11', '12', '13', '14', '15', '16', '17']
         repo: ['cpp-linter/cpp-linter']
-        branch: ['${{ inputs.branch }}']
+        branch: ['address-75'] # ['${{ inputs.branch }}']
       fail-fast: false
 
     steps:
@@ -42,7 +43,7 @@ jobs:
 
       - name: Cache the build artifacts
         id: cache-build
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: build
           key: ${{ hashFiles('src/CMakeLists.txt', 'src/demo.cpp', 'src/demo.hpp') }}
@@ -56,16 +57,18 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: >
-          cpp-linter 
-          -s=file 
-          -v=9 
-          -i=build 
-          -p=build 
-          -V=${{ runner.temp }}/llvm 
-          -f=false 
-          --extra-arg="-std=c++14 -Wall" 
-          --thread-comments=${{ matrix.clang-version == '12' }} 
-          -a=${{ matrix.clang-version == '12' }}
+          cpp-linter
+          -s=file
+          -v=9
+          -i=build
+          -p=build
+          -V=${{ runner.temp }}/llvm
+          --files-changed-only=true
+          --lines-changed-only=false
+          --extra-arg="-std=c++14 -Wall"
+          --thread-comments=${{ matrix.clang-version == '16' }}
+          --file-annotations=${{ matrix.clang-version == '16' }}
+          --tidy-review=${{ matrix.clang-version == '16' }}
 
       - name: Fail fast?!
         if: steps.linter.outputs.checks-failed > 0

diff --git a/src/demo.cpp b/src/demo.cpp
@@ -1,17 +1,18 @@
 /** This is a very ugly test code (doomed to fail linting) */
 #include "demo.hpp"
-#include <cstdio>
-#include <cstddef>
+#include <stdio.h>
-#include <stdio.h>
+#include <cstdio>
-#include <stdio.h>
+#include <cstdio>
-#include <stdio.h>
+#include <cstdio>
-#include <stdio.h>
+#include <cstdio>
 
-// using size_t from cstddef
-size_t dummyFunc(size_t i) { return i; }
 
-
+auto main() -> int
+{
-
+auto main() -> int
+{
-
+auto main() -> int
+{
-
+auto main() -> int
+{
-int main()
-{
-    for (;;)
-        break;
+
+
+int main(){
+
+    for (;;) break;
+
-
-
-int main(){
-
-    for (;;) break;
+    for (;;) {
+        break;
+    }
-
-
-int main(){
-
-    for (;;) break;
+    for (;;) {
+        break;
+    }
-
-
-int main(){
-
-    for (;;) break;
+    for (;;) {
+        break;
+    }
-
-
-int main(){
-
-    for (;;) break;
+    for (;;) {
+        break;
+    }
 
     printf("Hello world!\n");
 
-    return 0;
-}
+
+
+
+    return 0;}
-    return 0;}
+    return 0;
+}
-    return 0;}
+    return 0;
+}
-    return 0;}
+    return 0;
+}
-    return 0;}
+    return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
@@ -1,16 +1,14 @@
 #pragma once



 class Dummy {
     char* useless;
     int numb;
+    Dummy() :numb(0), useless("\0"){}
-    char* useless;
-    int numb;
-    Dummy() :numb(0), useless("\0"){}
+    char* useless { "\0" };
+    int numb { 0 };
+    Dummy() { }
-    char* useless;
-    int numb;
-    Dummy() :numb(0), useless("\0"){}
+    char* useless { "\0" };
+    int numb { 0 };
+    Dummy() { }
 
     public:
-    void *not_usefull(char *str){
-        useless = str;
-        return 0;
-    }
+    void *not_useful(char *str){useless = str;}
-    void *not_useful(char *str){useless = str;}
+        auto not_useful(char* str) -> void* { useless = str; }
-    public:
-    void *not_usefull(char *str){
-        useless = str;
-        return 0;
-    }
-    void *not_useful(char *str){useless = str;}
+public:
+    auto not_useful(char* str) -> void* { useless = str; }
-    void *not_useful(char *str){useless = str;}
+        auto not_useful(char* str) -> void* { useless = str; }
-    public:
-    void *not_usefull(char *str){
-        useless = str;
-        return 0;
-    }
-    void *not_useful(char *str){useless = str;}
+public:
+    auto not_useful(char* str) -> void* { useless = str; }
 };
 
 
@@ -28,14 +26,11 @@
 
 
 
-
-
-
-
 
 
 struct LongDiff
 {
+
     long diff;
 
 };