Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional code review observations on Attach() functionality from https://github.com/cucumber/godog/pull/623 #628

Merged
merged 5 commits into from
May 30, 2024

Conversation

Johnlon
Copy link
Member

@Johnlon Johnlon commented May 30, 2024

🤔 What's changed?

Added _example/attachments.
Added further test case for multiple calls to Attach() within a single step.
Code review comment applied - use a slice of object instead of slice of pointer

⚡️ What's your motivation?

Comments made here #623

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@Johnlon Johnlon changed the title Additional core review observations on Attach() functionality Additional code review observations on Attach() functionality from https://github.com/cucumber/godog/pull/623 May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 79.56%. Comparing base (153db4e) to head (2aea80c).
Report is 10 commits behind head on main.

Current head 2aea80c differs from pull request most recent head 15d425e

Please upload reports for the commit 15d425e to get more accurate results.

Files Patch % Lines
suite.go 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
- Coverage   83.21%   79.56%   -3.65%     
==========================================
  Files          28       40      +12     
  Lines        3413     3117     -296     
==========================================
- Hits         2840     2480     -360     
- Misses        458      518      +60     
- Partials      115      119       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Johnlon Johnlon enabled auto-merge (squash) May 30, 2024 02:28
@Johnlon Johnlon merged commit 9558224 into cucumber:main May 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant