Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional code review observations on Attach() functionality from https://github.com/cucumber/godog/pull/623 #628

Merged
merged 5 commits into from
May 30, 2024
Merged

Additional code review observations on Attach() functionality from https://github.com/cucumber/godog/pull/623 #628

merged 5 commits into from
May 30, 2024

Commits on May 30, 2024

  1. support multiple calls to the Attach() function from a single step

    @Johnlon
    Johnlon committed May 30, 2024
    Configuration menu
    Copy the full SHA
    0ebc153 View commit details
    Browse the repository at this point in the history

  2. run_progress_test.go changed so it's not sensitive to the name of the… 

    … clone target directory
    @Johnlon
    Johnlon committed May 30, 2024
    Configuration menu
    Copy the full SHA
    276cca3 View commit details
    Browse the repository at this point in the history

  3. applied code review comments also added _example/attachments

    @Johnlon
    Johnlon committed May 30, 2024
    Configuration menu
    Copy the full SHA
    137cbf3 View commit details
    Browse the repository at this point in the history

  4. applied code review comments also added _example/attachments

    @Johnlon
    Johnlon committed May 30, 2024
    Configuration menu
    Copy the full SHA
    2aea80c View commit details
    Browse the repository at this point in the history

  5. applied code review comments also added _example/attachments

    @Johnlon
    Johnlon committed May 30, 2024
    Configuration menu
    Copy the full SHA
    15d425e View commit details
    Browse the repository at this point in the history