-
-
Notifications
You must be signed in to change notification settings - Fork 22
Add location to pickle #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
In all other objects that contain a Location, by convention, the Location is the first property mentioned and thus the first parameter in the generated constructors. This proposed change has the Location as the last property mentioned; and thus the last parameter in the parameter list. This inconsistency is a bit jarring. Can we move it up to the top of the property list? |
|
For Examples(Scenario Outlines), what is the proper Location of the pickle resulting from the table? |
Sure!
The pickle location is the same as the location of the example row used to create the pickle. The line of the scenario outline would not uniquely identify the pickle as it could refer to any of the examples in that scenario outline. |
|
Out of interest, why is this bound up with the move to Java 17? Just to group breaking changes in one release? |
|
No. Looks like I copy pasted the content intended for #352 into this issue. |
# Conflicts: # jsonschema/messages.md
🤔 What's changed?
Add (optional)
locationfield to thePicklemessage.⚡️ What's your motivation?
Finding the source location of a pickle without having to dive into the Gherkin AST and/or bring in one of the query libraries. Helps with, among other things:
🏷️ What kind of change is this?
📋 Checklist: