Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update apn sample app with 3rd party SDK that handles push #225

Merged
merged 10 commits into from
Feb 12, 2024
Merged

test: update apn sample app with 3rd party SDK that handles push #225

merged 10 commits into from
Feb 12, 2024

Conversation

levibostian
Copy link
Contributor

@levibostian levibostian commented Dec 11, 2023 •
edited
Loading

Setup APN sample app to be able to test new iOS feature: https://github.com/customerio/issues/issues/11289

@levibostian levibostian force-pushed the levi/reliable-open-metrics-apn-sample branch from d2aa74b to 05efea3 Compare December 11, 2023 20:26
@levibostian levibostian requested a review from a team December 11, 2023 20:27
@levibostian levibostian changed the title tests: update apn sample app with 3rd party SDK that handles push test: update apn sample app with 3rd party SDK that handles push Dec 11, 2023
ami-aman
ami-aman approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@ami-aman ami-aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a few non-blocker suggestions.

@levibostian levibostian mentioned this pull request Jan 4, 2024
Merged
Shahroz16
Shahroz16 requested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@Shahroz16 Shahroz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the comment here again, so it doesn't get missed because i think it could be very important

@levibostian levibostian requested a review from Shahroz16 January 8, 2024 16:51
@levibostian levibostian mentioned this pull request Feb 12, 2024
Merged
Base automatically changed from levi/reliable-open-metrics to main February 12, 2024 15:57
@levibostian levibostian merged commit 1de66b6 into main Feb 12, 2024
6 checks passed
@levibostian levibostian deleted the levi/reliable-open-metrics-apn-sample branch February 12, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ami-aman ami-aman ami-aman approved these changes

@Shahroz16 Shahroz16 Shahroz16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@levibostian @Shahroz16 @ami-aman