Fix a problem with using the Google ChromeDriver not getting sessionId#5
Open
colinnewell wants to merge 2 commits intocv-library:masterfrom
Open
Fix a problem with using the Google ChromeDriver not getting sessionId#5colinnewell wants to merge 2 commits intocv-library:masterfrom
colinnewell wants to merge 2 commits intocv-library:masterfrom
Conversation
colinnewell
force-pushed
the
chromedriver
branch
from
dfe02a5 to
c0b1b81
Compare
Probably fixed in the ugliest way possible.
colinnewell
force-pushed
the
chromedriver
branch
from
c0b1b81 to
946f1ff
Compare
Contributor
Author
|
This is really just waiting integration with a chrome container to test it and spot atrophy. |
tomhukins
approved these changes
Jan 14, 2021
Contributor
tomhukins
left a comment
tomhukins
left a comment
There was a problem hiding this comment.
It seems like a very good idea to automatically test against Chrome. Two and a half years after this work was done, what do we need to do to get it merged?
Contributor
Author
|
Looks like I started to add the chrome container to the tests, but didn't get the tests passing. I guess someone just needs to get these changes up to date with master, and then get the tests passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably fixed in the ugliest way possible.